Skip to content

Fix memleak in ConfKeyValues#15488

Merged
sawenzel merged 1 commit into
AliceO2Group:devfrom
f3sch:fix/mem/confkey
Jun 8, 2026
Merged

Fix memleak in ConfKeyValues#15488
sawenzel merged 1 commit into
AliceO2Group:devfrom
f3sch:fix/mem/confkey

Conversation

@f3sch

@f3sch f3sch commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

getDataMembers() returns a pointer to a new std::vector. Wrapping the callsites in a managed ptr, gets rid of these small leaks.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch requested a review from sawenzel as a code owner June 4, 2026 19:14
@alibuild

alibuild commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for ebfc35a at 2026-06-06 17:26:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:180:39: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:182:40: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:184:47: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:188:39: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:190:40: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:192:47: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@sawenzel sawenzel merged commit 2c94782 into AliceO2Group:dev Jun 8, 2026
11 of 12 checks passed
@f3sch f3sch deleted the fix/mem/confkey branch June 8, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants