Merge pull request #37 from ConvertAPI/fix/converter-param-case

Make converter param name case insensitive

Author: laurynas-convertapi

convertapi/task.py

@@ -21,10 +21,11 @@ def run(self):
         params = self.__normalize_params()
         from_format = self.from_format or self.__detect_format()
         timeout = self.timeout + convertapi.conversion_timeout_delta if self.timeout else None
+        converter = self.__detect_converter()
         path = "convert/%s/to/%s" % (from_format, self.to_format)
 
-        if 'converter' in params:
-            path += "/converter/%s" % (params['converter'])
+        if converter != None:
+            path += "/converter/%s" % (converter)
 
         response = convertapi.client.post(path, params, timeout = timeout)
 
@@ -61,3 +62,10 @@ def __detect_format(self):
 
         if 'Files' in self.params:
             return format_detector.detect(self.params['Files'][0])
+
+    def __detect_converter(self):
+        for k, v in self.params.items():
+            if k.lower() == 'converter':
+                return v
+
+        return None

tests/test_convertapi.py

@@ -30,7 +30,7 @@ def test_convert_file_no_parallelizm(self):
 		assert result.save_files(tempfile.gettempdir())
 
 	def test_convert_file_alternative(self):
-		result = convertapi.convert('pdf', { 'File': 'examples/files/test.docx', 'converter': 'openoffice' })
+		result = convertapi.convert('pdf', { 'File': 'examples/files/test.docx', 'Converter': 'openoffice' })
 		assert result.save_files(tempfile.gettempdir())
 		assert result.conversion_cost > 0