Return results more than print them in the same function.

[mysticmalard]

While writing a GUI program with framework_lib, I've noticed and become somewhat frustrated that most of the functions and EC methods get AND PRINT their results instead of returning them. This means that I can't use those functions unless I want to print that data in the same format that the cli tool does. I understand it's probably not the easiest thing to do, but would it be possible to change this so that those functions are more reusable?

[JohnAZoidberg]

Yes, that's not wrong. Valid concern.

Well kind of. Most is implemented in framework_lib/src/chromium_ec/mod.rs where nothing prints and everything is returned as a value.
But many things are further decoded in higher level functions spread in various files.

Maybe you can start with some specific needs you have and we can start from there?
Of course even better, if you could help implement and suggest changes :D

[mysticmalard]

Wow, I can't believe I got a response, this is like my first issue I've ever opened. Anyways, at the moment I'm working through CrosEc.check_bay_status. Trying to query info abt the hardware, and I'll probably be moving on to thermals soon.

I'd love to help implement changes like this, but I'm new enough to Rust that I learned what the ? operator does like an hour ago. So, I don't feel like I really know what I'm doing, but I'm a quick learner (Famous last words) :D

[JohnAZoidberg]

You're welcome :D

You can look into check_bay_status and grab what you need. It calls a few functions or rather sends a few host commands that each respond with just data.

I'll probably be moving on to thermals soon.

Ohh yeah sorry the thermals file is quite a mess right now.

I'd love to help implement changes like this, but I'm new enough to Rust that I learned what the ? operator does like an hour ago. So, I don't feel like I really know what I'm doing, but I'm a quick learner (Famous last words) :D

Enjoy the journey!

[mysticmalard]

One other unrelated idea that I had that, while it would be cool, is probably infeasible. Is there enough going on inside the power adapters that it could report it's temperature (or current power output) to the pd controllers? Do they even do any communicating past the PD contract?

Wouldn't assume so but it's worth asking.

[JohnAZoidberg]

That's not possible, there's no standard way to report that data. Maybe some adapters have an undocumented proprietary protocol to do that, but I'm not aware of it.