fix(run-info): add PERIODTYPE to hardware info dropdown#330
Open
64johnlee wants to merge 1 commit into
Open
Conversation
PERIODTYPE (DAE:PERIODTYPE) was missing from the runInfoPVs map that populates the show/hide hardware info dropdown in TopBar. Added it alongside the other period-related PVs (PERIOD, PERIODSEQ, etc.) so it is subscribed via websocket and displayed in the dropdown the same way as all other run information variables. Closes ISISComputingGroup#329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PERIODTYPE(DAE:PERIODTYPE) was missing from therunInfoPVsmap inInstrument.ts, which populates the show/hide all hardware info dropdown in the TopBar. This adds it alongside the other period-related PVs so it is subscribed via websocket and displayed in the dropdown in the same way as all other run information variables.Closes #329
Changes
app/components/Instrument.ts— addedDAE:PERIODTYPE/ "Period Type" entry torunInfoPVsafterPERIODSEQapp/components/__snapshots__/TopBar.test.ts.snap— updated snapshot to include new "Period Type" rowTest plan
npm testpasses (84 tests, 1 snapshot updated)