Warning when calculated hit damage exceeds hit damage cap

[Spirit3k]

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

Hits above 2.147... billion deal no damage in-game. (personally tested in game this week, wiki will be updated soon)

Describe the solution you'd like

A warning in pob to let people know. Nothing more heavy-handed is warranted imo.

Describe alternatives you've considered

none

Additional context

No response

[Spirit3k]

More detail for the interested :
I only tested the 0-4billion ranges, sometimes damage occurred above 6b but I didn't test wrap-around damage since there's too many unknown unknowns.
Probably the warning should be something like "Overflow damage can be positive or negative but PoB cannot predict the outcome" rather than "this will deal no damage"

[LocalIdentity]

This is a bug with the game and not PoB. Going over 2 billion in the past had no issues

[Spirit3k]

But

You said it yourself
https://www.reddit.com/r/pathofexile/comments/115mmjk/comment/j93dod2/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

I just want the warning you considered T_T

[LocalIdentity]

Yeah sorry @Spirit3k I was focused on seeing the bug with the no damge and didn't consider the warning for going over the cap
it's really hard to test at what stage ggg implements the limit too

[Spirit3k]

I know XD

Do you want a synthesis of my findings? It's on the prohib library discord fwiw

[Spirit3k]

This is a sample of the equipment used to test damage in-game : https://pobb.in/7-DenTkiE-3U

Some results :

-damage on full life, -cruelty, -call of the brotherhood +arcane cloak 1.9bil mainhand (33-66 lighting chaos), 3.9bil total
result : not kill

-damage on full life, -cruelty, -call of the brotherhood -fortify -ele dam with attacks +arcane cloak 1.1bil mainhand (33-66 lighting chaos), 2.3bil total
Result : not kill

-damage on full life, -cruelty, -call of the brotherhood -fortify -ele dam with attacks -ele focus +arcane cloak 854mil mainhand (33-66 lighting chaos), 1.7bil total
result: kill

-cruelty, -call of the brotherhood -fortify +seismic cry 1bil mainhand (33-66 lighting chaos), 2.1bil total
result: kill

-cruelty, -call of the brotherhood +seismic cry 1.2bil mainhand (33-66 lighting chaos), 2.5bil total
result: not kill

+seismic cry +arcane cloak -dual strike +double strike 1.9bil mainhand (33-66 lighting chaos), 1.9bil twice total
result: kill

Crit was tested using a different setup to avoid the lightning bolt from the amulet confounding results : https://pobb.in/7NizqontMR3M

Same results, no damage was dealt to mobs when pob calculated damage was in the 2.2-3.9b range
(Most of the testing was done on act 1 white mobs)

All testing caused damage when pob number was lower than 2.147b