fix: normalise AddContent path separators to forward slash on PS5.1#465
Merged
Conversation
Test Results 4 files 284 suites 1m 19s ⏱️ Results for commit 4ab9644. ♻️ This comment has been updated with latest results. |
Get-ChildItem -Name returns backslash-separated paths on PS5.1 Windows. Manifest source/destination attributes now always use forward slashes for cross-platform consistency. Updates the test fixture accordingly (removing the $IsWindows separator branch, which was $null on PS5.1 anyway).
HeyItsGilbert
force-pushed
the
fix/ps51-path-separator
branch
from
980aca1 to
4ab9644
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Get-ChildItem -Namereturns backslash-separated paths on PS5.1 Windows, causing generated manifestsource/destinationattributes to use\instead of/New-PlasterManifest.ps1: call.Replace('\', '/')on each filename before writing thesourceanddestinationattributes, in both the XML and JSON manifest pathstests/New-PlasterManifest.Tests.ps1: removes the$IsWindowsseparator branch (which evaluated to$null/false on PS5.1 anyway) and hardcodes/, matching the now-normalised output on all platformsTest plan
AddContent parameter workspasses🤖 Generated with Claude Code