Skip to content

Workspace comment move events retain references to comment objects #10219

Description

@gonfunko

CommentMove has a comment_ field, which stores a reference to the moved workspace comment. This results in deleted workspace comments persisting indefinitely, as comment move events are kept alive in the undo stack, and in turn keep the underlying comment alive. This field is also writable, which could lead to the event being modified in a non-sensible fashion. The field was originally documented as being cleared after initialization of the event, but somewhere along the line that comment and the underlying behavior was lost. All other event types just store an ID, and CommentMove does as well, inherited from its superclass. This field should probably just be eliminated entirely, but this is a breaking change and needs to wait for v14. In the meantime, the field should be marked as deprecated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions