Skip to content

Add missing zones to enus#41

Open
jackpoz wants to merge 4 commits into
TrinityCore:masterfrom
jackpoz:fixes/zone-names
Open

Add missing zones to enus#41
jackpoz wants to merge 4 commits into
TrinityCore:masterfrom
jackpoz:fixes/zone-names

Conversation

@jackpoz

@jackpoz jackpoz commented Dec 31, 2020

Copy link
Copy Markdown
Member

Include the zones retrieved with this query (which might not be correct but it adds a lot of zones):

SELECT CONCAT(LPAD(id, 4, " "), ": '", REPLACE(name_loc0, '\'', '\\\''), "',") FROM aowow.aowow_zones;

Fixes Sarjuuk#227

@jackpoz

jackpoz commented Jan 2, 2021

Copy link
Copy Markdown
Member Author

@Sarjuuk could you take a look at this ?

@Sarjuuk

Sarjuuk commented Jan 3, 2021

Copy link
Copy Markdown
Collaborator

Refering to Sarjuuk#227, this doesn't fix the real problem that the assigned zone is wrong. You just give a name to the wrong zone.

you might argue future-proofing the js variables for custom Quest zoneOrSort but even then this PR only provides locales to the frontend static/js/locale_xxXX.js) in 1 out of 6 locales and none to the backend localization/locale_xxXX.php

@jackpoz

jackpoz commented Jan 3, 2021

Copy link
Copy Markdown
Member Author

well, what about https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=2918 ? is that wrong zone too ? or is it missing the zone name only ?

@Sarjuuk

Sarjuuk commented Jan 3, 2021

Copy link
Copy Markdown
Collaborator

those were instanced until wotlk, when they became part of the open world. (no idea why there are still NPCs spawned inside)

areaTable.dbc id: 2918 => mapId: 449
map.dbc id: 449 => name_loc0 => AlliancePVPBarracks

@jackpoz

jackpoz commented Jan 3, 2021

Copy link
Copy Markdown
Member Author

it sounds good if you want to close this PR, but please reopen Sarjuuk#227 . Let me know if there is something to do to fix it (I guess you have the same issue locally or ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sunken Temple appears on lists as "undefined"

2 participants