docs: fix inaccuracies and add missing required flags in action.yml#721
Open
kranthipoturaju wants to merge 1 commit into
Open
docs: fix inaccuracies and add missing required flags in action.yml#721kranthipoturaju wants to merge 1 commit into
kranthipoturaju wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Documentation and metadata refinements to action.yml: clarifies input/output descriptions and explicitly marks optional inputs as required: false.
Changes:
- Added
required: falseto optional inputs for explicitness/consistency. - Clarified descriptions for
user-agent,result-encoding, and theresultoutput.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects inaccuracies and fills documentation gaps in
action.ymlto accurately reflect the current implementation insrc/main.tsandsrc/retry-options.ts. No behavior or code changes are included.Changes
resultoutput description fixed: Previously stated the result is always "stringified withJSON.stringify", which is only true forresult-encoding: json. Whenresult-encoding: string, the output usesString(). Description now covers both paths.result-encodingdescription improved: Removed the redundant(default "json")phrase (already declared in thedefault:field) and replaced with the concrete JS functions used for each mode.user-agentdescription updated: TheACTIONS_ORCHESTRATION_IDenvironment variable is read at runtime inmain.tsand silently appended to the user-agent string. This behavior was entirely undocumented inaction.yml.required: falseadded to all implicitly optional inputs:debug,user-agent,previews,result-encoding,retries, andretry-exempt-status-codeswere all optional but lacked the explicit flag.previewsin particular had neither adefault:norrequired: false, making its optionality ambiguous to tooling and readers.Motivation
action.ymlis the primary machine-readable and human-readable contract for this action. Inaccurate descriptions mislead users and tooling (IDE completions,actionlint, documentation generators). Theresultoutput description was factually wrong for thestringencoding path, and the undocumentedACTIONS_ORCHESTRATION_IDbehavior was invisible to users trying to understand or debug user-agent strings in audit logs.Impact
actionlintand schema validators now see explicitrequired: falseon all optional inputs, reducing false-positive warnings.Testing
action.ymlis a metadata file with no executable logic. The change was validated by:src/main.ts(result-encodingswitch,getUserAgentWithOrchestrationId,core.getInputcalls).git diffto confirm the diff is strictly additive to descriptions andrequired: falseflags with no structural changes.