Prefill custom compute offering values for VMware import

[andrijapanicsb]

Summary

• Fix unconstrained custom offering defaults during VMware import.
• Keep constrained custom offering behavior intact, while making it explicit and consistent.
• Default unknown CPU speed to 2000 MHz instead of showing/importing 0 MHz.

Problem

When importing a VMware VM and selecting a custom unconstrained compute offering, the UI could prefill the custom fields with generic fallback values instead of the discovered source VM sizing:

• CPU cores: 1
• CPU speed: 0 MHz
• Memory: 32 MB

This happened even when the source VM details already showed useful sizing information, for example 3 CPU and 4096 MB memory.

Existing Behavior

• Custom constrained offerings already behave correctly because the UI receives serviceofferingdetails with min/max CPU and memory bounds.
• With those bounds present, the custom input component can initialize CPU and memory from values inside the allowed range.

• Custom unconstrained offerings do not have those min/max bounds, so the UI falls back to generic defaults: 1 CPU, 0 MHz, and 32 MB.

New Behavior

• Custom constrained offerings: continue to prefill from the discovered source VM sizing, clamped to the configured min/max range.
• Custom unconstrained offerings: now also prefill from the discovered source VM sizing instead of using the generic fallback values.
• Unknown source CPU speed: if VMware reports CPU speed as 0 or unknown, the UI now defaults the custom CPU speed field to 2000 MHz.
• Selection refresh: the custom compute input row is recreated when the selected offering or discovered sizing values change, so stale custom values are not retained.

Testing

• Ran git diff --check.
• Verified the pull request diff only changes ui/src/views/tools/ImportUnmanagedInstance.vue.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.10%. Comparing base (a0aafe2) to head (765f166).

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #13237   +/-   ##
=========================================
  Coverage     18.10%   18.10%           
- Complexity    16746    16748    +2     
=========================================
  Files          6037     6037           
  Lines        542933   542945   +12     
  Branches      66487    66494    +7     
=========================================
+ Hits          98283    98292    +9     
- Misses       433602   433605    +3     
  Partials      11048    11048           

Flag	Coverage Δ
uitests	3.51% <ø> (-0.01%)	⬇️
unittests	19.26% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[andrijapanicsb]

@blueorangutan UI

[andrijapanicsb]

@blueorangutan package

[blueorangutan]

@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18023

[Copilot]

Pull request overview

This PR improves the VMware unmanaged-instance import flow by ensuring custom compute offering inputs are prefilled from the discovered source VM sizing (instead of generic fallback defaults), and by forcing a refresh of the custom input component when the selected offering or discovered sizing changes.

Changes:

• Force <compute-selection> to be recreated when the selected offering or discovered CPU/memory/speed values change (via a computed :key).
• Introduce a computed prefill payload for custom compute offerings that clamps CPU/memory to constrained min/max when applicable.
• Default unknown/zero CPU speed to 2000 MHz when using custom offerings.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.