fix: inline DynamoDB property prefix removal

Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>

Author: anxkhn

pyiceberg/catalog/dynamodb.py

@@ -837,7 +837,10 @@ def _get_update_database_item(namespace_item: dict[str, Any], updated_properties
 
 
 def _get_namespace_properties(namespace_dict: dict[str, str]) -> Properties:
-    return {_remove_property_prefix(key): val for key, val in namespace_dict.items() if key.startswith(PROPERTY_KEY_PREFIX)}
+    # removeprefix removes the literal prefix, unlike lstrip which removes any leading prefix characters
+    return {
+        key.removeprefix(PROPERTY_KEY_PREFIX): val for key, val in namespace_dict.items() if key.startswith(PROPERTY_KEY_PREFIX)
+    }
 
 
 def _convert_dynamo_item_to_regular_dict(dynamo_json: dict[str, Any]) -> dict[str, str]:
@@ -888,7 +891,3 @@ def _convert_dynamo_item_to_regular_dict(dynamo_json: dict[str, Any]) -> dict[st
 
 def _add_property_prefix(prop: str) -> str:
     return PROPERTY_KEY_PREFIX + prop
-
-
-def _remove_property_prefix(prop: str) -> str:
-    return prop.removeprefix(PROPERTY_KEY_PREFIX)

tests/catalog/test_dynamodb.py

@@ -502,26 +502,6 @@ def test_load_namespace_properties(_bucket_initialize: None, database_name: str)
         assert v == test_properties[k]
 
 
-@mock_aws
-def test_load_namespace_properties_with_prefix_char_keys(_bucket_initialize: None, database_name: str) -> None:
-    # Property keys starting with a character in the "p." prefix (e.g. "p" or ".") must
-    # survive a round trip. The stored keys are prefixed with PROPERTY_KEY_PREFIX ("p."),
-    # so decoding must strip only that literal prefix, not any leading "p"/"." characters.
-    test_properties = {
-        "provider": "s3",
-        "path": f"s3://{BUCKET_NAME}/{database_name}.db",
-        "ppp": "3",
-        ".hidden": "yes",
-        "comment": "not affected",
-    }
-    test_catalog = DynamoDbCatalog("test_ddb_catalog")
-    test_catalog.create_namespace(database_name, test_properties)
-    listed_properties = test_catalog.load_namespace_properties(database_name)
-    for k, v in test_properties.items():
-        assert k in listed_properties
-        assert listed_properties[k] == v
-
-
 @mock_aws
 def test_load_non_exist_namespace_properties(_bucket_initialize: None, database_name: str) -> None:
     test_catalog = DynamoDbCatalog("test_ddb_catalog")