From cef4fb4fc8a607e6c46d20579e299542ed074e07 Mon Sep 17 00:00:00 2001
From: "Piotr P. Karwasz" <pkarwasz-github@apache.org>
Date: Sat, 1 Aug 2026 00:11:02 +0200
Subject: [PATCH] Adjust PMD violation ceilings to PMD 7 counts

The maven-pmd-plugin 3.15.0 to 3.28.0 bump (#479) switched from PMD 6
to PMD 7.17.0, which finds a different violation mix in most modules.
Ratchet each module's `pmd.maxAllowedViolations` to the new actual
count so the build passes again. The counts rise in some modules and
drop in others (flume-ng-sdk goes from 170 to 30); fixing the
violations themselves remains a TODO.

Assisted-By: Claude Fable 5 <noreply@anthropic.com>
---
 flume-ng-auth/pom.xml                                    | 2 +-
 flume-ng-channels/flume-file-channel/pom.xml             | 2 +-
 flume-ng-channels/flume-spillable-memory-channel/pom.xml | 2 +-
 flume-ng-configuration/pom.xml                           | 2 +-
 flume-ng-core/pom.xml                                    | 2 +-
 flume-ng-instrumentation/flume-ganglia-monitor/pom.xml   | 3 ++-
 flume-ng-node/pom.xml                                    | 2 +-
 flume-ng-sdk/pom.xml                                     | 2 +-
 flume-ng-sources/flume-syslog-source/pom.xml             | 3 ++-
 flume-ng-sources/flume-taildir-source/pom.xml            | 2 +-
 10 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/flume-ng-auth/pom.xml b/flume-ng-auth/pom.xml
index ae6c7dbbbc..e288313d1e 100644
--- a/flume-ng-auth/pom.xml
+++ b/flume-ng-auth/pom.xml
@@ -32,7 +32,7 @@
   <properties>
     <!-- TODO fix spotbugs/pmd violations -->
     <spotbugs.maxAllowedViolations>6</spotbugs.maxAllowedViolations>
-    <pmd.maxAllowedViolations>7</pmd.maxAllowedViolations>
+    <pmd.maxAllowedViolations>5</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.auth</module.name>
   </properties>
 
diff --git a/flume-ng-channels/flume-file-channel/pom.xml b/flume-ng-channels/flume-file-channel/pom.xml
index 70c26cd006..245e4d5679 100644
--- a/flume-ng-channels/flume-file-channel/pom.xml
+++ b/flume-ng-channels/flume-file-channel/pom.xml
@@ -31,7 +31,7 @@
   <properties>
     <!-- TODO fix spotbugs violations -->
     <spotbugs.maxAllowedViolations>162</spotbugs.maxAllowedViolations>
-    <pmd.maxAllowedViolations>19</pmd.maxAllowedViolations>
+    <pmd.maxAllowedViolations>21</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.channel.file</module.name>
   </properties>
 
diff --git a/flume-ng-channels/flume-spillable-memory-channel/pom.xml b/flume-ng-channels/flume-spillable-memory-channel/pom.xml
index 70c8d54107..b891a42aae 100644
--- a/flume-ng-channels/flume-spillable-memory-channel/pom.xml
+++ b/flume-ng-channels/flume-spillable-memory-channel/pom.xml
@@ -31,7 +31,7 @@
   <properties>
     <!-- TODO fix spotbugs/pmd violations -->
     <spotbugs.maxAllowedViolations>11</spotbugs.maxAllowedViolations>
-    <pmd.maxAllowedViolations>8</pmd.maxAllowedViolations>
+    <pmd.maxAllowedViolations>4</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.channel.spillable.memory</module.name>
   </properties>
 
diff --git a/flume-ng-configuration/pom.xml b/flume-ng-configuration/pom.xml
index 1c86eaf997..8ab25fd658 100644
--- a/flume-ng-configuration/pom.xml
+++ b/flume-ng-configuration/pom.xml
@@ -29,7 +29,7 @@
   <properties>
     <!-- TODO fix spotbugs violations -->
     <spotbugs.maxAllowedViolations>36</spotbugs.maxAllowedViolations>
-    <pmd.maxAllowedViolations>17</pmd.maxAllowedViolations>
+    <pmd.maxAllowedViolations>13</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.conf</module.name>
   </properties>
 
diff --git a/flume-ng-core/pom.xml b/flume-ng-core/pom.xml
index 61c505c9d9..e8b6a0d28c 100644
--- a/flume-ng-core/pom.xml
+++ b/flume-ng-core/pom.xml
@@ -33,7 +33,7 @@
   <properties>
     <!-- TODO fix spotbugs violations -->
     <spotbugs.maxAllowedViolations>152</spotbugs.maxAllowedViolations>
-    <pmd.maxAllowedViolations>64</pmd.maxAllowedViolations>
+    <pmd.maxAllowedViolations>69</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.core</module.name>
   </properties>
 
diff --git a/flume-ng-instrumentation/flume-ganglia-monitor/pom.xml b/flume-ng-instrumentation/flume-ganglia-monitor/pom.xml
index 2e531ee8be..1911b1209f 100644
--- a/flume-ng-instrumentation/flume-ganglia-monitor/pom.xml
+++ b/flume-ng-instrumentation/flume-ganglia-monitor/pom.xml
@@ -32,8 +32,9 @@
   <properties>
     <!-- This artifact was never released before -->
     <bnd.baseline.fail.on.missing>false</bnd.baseline.fail.on.missing>
-    <!-- TODO fix spotbugs violations -->
+    <!-- TODO fix spotbugs/pmd violations -->
     <spotbugs.maxAllowedViolations>13</spotbugs.maxAllowedViolations>
+    <pmd.maxAllowedViolations>3</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.instrumentation.ganglia</module.name>
   </properties>
 
diff --git a/flume-ng-node/pom.xml b/flume-ng-node/pom.xml
index 4fae3f83e8..40f6a4d090 100644
--- a/flume-ng-node/pom.xml
+++ b/flume-ng-node/pom.xml
@@ -32,7 +32,7 @@
   <properties>
     <!-- TODO fix spotbugs violations -->
     <spotbugs.maxAllowedViolations>12</spotbugs.maxAllowedViolations>
-    <pmd.maxAllowedViolations>7</pmd.maxAllowedViolations>
+    <pmd.maxAllowedViolations>5</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.node</module.name>
     <junit-jupiter.version>6.1.2</junit-jupiter.version>
   </properties>
diff --git a/flume-ng-sdk/pom.xml b/flume-ng-sdk/pom.xml
index a5c0a4a095..bbe85ee1e3 100644
--- a/flume-ng-sdk/pom.xml
+++ b/flume-ng-sdk/pom.xml
@@ -32,7 +32,7 @@
   <properties>
     <!-- TODO fix spotbugs/pmd violations -->
     <spotbugs.maxAllowedViolations>69</spotbugs.maxAllowedViolations>
-    <pmd.maxAllowedViolations>170</pmd.maxAllowedViolations>
+    <pmd.maxAllowedViolations>30</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.sdk</module.name>
   </properties>
 
diff --git a/flume-ng-sources/flume-syslog-source/pom.xml b/flume-ng-sources/flume-syslog-source/pom.xml
index d169d16458..e45b597f72 100644
--- a/flume-ng-sources/flume-syslog-source/pom.xml
+++ b/flume-ng-sources/flume-syslog-source/pom.xml
@@ -32,8 +32,9 @@
   <properties>
     <!-- This artifact was never released before -->
     <bnd.baseline.fail.on.missing>false</bnd.baseline.fail.on.missing>
-    <!-- TODO fix spotbugs violations -->
+    <!-- TODO fix spotbugs/pmd violations -->
     <spotbugs.maxAllowedViolations>8</spotbugs.maxAllowedViolations>
+    <pmd.maxAllowedViolations>1</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.source.syslog</module.name>
   </properties>
 
diff --git a/flume-ng-sources/flume-taildir-source/pom.xml b/flume-ng-sources/flume-taildir-source/pom.xml
index c4e34bb06a..89edc39556 100644
--- a/flume-ng-sources/flume-taildir-source/pom.xml
+++ b/flume-ng-sources/flume-taildir-source/pom.xml
@@ -32,7 +32,7 @@
   <properties>
     <!-- TODO fix spotbugs/pmd violations -->
     <spotbugs.maxAllowedViolations>24</spotbugs.maxAllowedViolations>
-    <pmd.maxAllowedViolations>3</pmd.maxAllowedViolations>
+    <pmd.maxAllowedViolations>4</pmd.maxAllowedViolations>
     <module.name>org.apache.flume.source.taildir</module.name>
   </properties>