From 8a0fcc9ee8b44fd395af206693dd4bc724857a38 Mon Sep 17 00:00:00 2001 From: Ayushi Ahjolia Date: Mon, 29 Jun 2026 17:58:14 -0700 Subject: [PATCH] chore(lint): Enable Pyflakes rules across all packages --- .github/scripts/tests/test_lintcommit.py | 1 - .../cli.py | 2 +- .../pyproject.toml | 2 +- .../src/callback/callback_mixed_ops.py | 1 - .../src/callback/callback_serdes.py | 2 +- .../filesystem_serdes/filesystem_serdes_basic.py | 2 -- .../src/map/map_completion.py | 2 +- .../wait_for_callback_serdes.py | 2 +- .../wait_for_callback_submitter_failure.py | 2 +- .../test/callback/test_callback_mixed_ops.py | 1 - .../test/callback/test_callback_serdes.py | 1 - .../test/map/test_map_operations.py | 1 - ...est_wait_for_callback_multiple_invocations.py | 1 - .../test_wait_for_callback_serdes.py | 1 - .../test_wait_for_callback_submitter_failure.py | 2 -- ...t_for_callback_submitter_failure_catchable.py | 1 - .../test_wait_for_condition.py | 2 -- .../pyproject.toml | 2 +- .../tests/test_deterministic_id_generator.py | 1 - .../pyproject.toml | 2 +- .../cli.py | 1 - .../executor.py | 3 --- .../runner.py | 4 +--- .../web/handlers.py | 2 -- .../web/serialization.py | 3 +-- .../tests/executor_test.py | 1 - .../tests/invoker_test.py | 1 - .../tests/runner_test.py | 7 ------- .../tests/stores/filesystem_store_test.py | 2 -- .../tests/web/handlers_test.py | 2 -- .../tests/web/models_test.py | 1 - .../pyproject.toml | 2 +- .../concurrency/executor.py | 2 +- .../aws_durable_execution_sdk_python/context.py | 1 - .../execution.py | 2 -- .../filesystem_serdes.py | 1 - .../operation/step.py | 3 --- .../operation/wait_for_condition.py | 2 -- .../aws_durable_execution_sdk_python/state.py | 4 +--- .../tests/concurrency_test.py | 2 -- .../tests/e2e/checkpoint_response_int_test.py | 2 +- .../tests/e2e/filesystem_serdes_int_test.py | 16 ++-------------- .../tests/filesystem_serdes_test.py | 1 - pyproject.toml | 2 +- 44 files changed, 17 insertions(+), 81 deletions(-) diff --git a/.github/scripts/tests/test_lintcommit.py b/.github/scripts/tests/test_lintcommit.py index 42c4233..6abed47 100644 --- a/.github/scripts/tests/test_lintcommit.py +++ b/.github/scripts/tests/test_lintcommit.py @@ -9,7 +9,6 @@ sys.path.insert(0, os.path.dirname(os.path.dirname(__file__))) -import pytest from lintcommit import lint_range, validate_message, validate_subject # region validate_subject: valid subjects diff --git a/packages/aws-durable-execution-sdk-python-examples/cli.py b/packages/aws-durable-execution-sdk-python-examples/cli.py index fe02dae..42b61ef 100755 --- a/packages/aws-durable-execution-sdk-python-examples/cli.py +++ b/packages/aws-durable-execution-sdk-python-examples/cli.py @@ -20,7 +20,7 @@ try: import boto3 - from aws_durable_execution_sdk_python.lambda_service import LambdaClient + from aws_durable_execution_sdk_python.lambda_service import LambdaClient # noqa: F401 except ImportError: sys.exit(1) diff --git a/packages/aws-durable-execution-sdk-python-examples/pyproject.toml b/packages/aws-durable-execution-sdk-python-examples/pyproject.toml index cd87c2d..6e5d789 100644 --- a/packages/aws-durable-execution-sdk-python-examples/pyproject.toml +++ b/packages/aws-durable-execution-sdk-python-examples/pyproject.toml @@ -22,7 +22,7 @@ target-version = "py311" [tool.ruff.lint] preview = true -select = ["TID252"] # Enforce absolute imports (ban relative imports) +select = ["F", "TID252"] # Pyflakes (unused imports, undefined names, etc.) + absolute imports [tool.ruff.lint.isort] known-first-party = ["aws_durable_execution_sdk_python"] diff --git a/packages/aws-durable-execution-sdk-python-examples/src/callback/callback_mixed_ops.py b/packages/aws-durable-execution-sdk-python-examples/src/callback/callback_mixed_ops.py index 089b17d..07e7608 100644 --- a/packages/aws-durable-execution-sdk-python-examples/src/callback/callback_mixed_ops.py +++ b/packages/aws-durable-execution-sdk-python-examples/src/callback/callback_mixed_ops.py @@ -1,6 +1,5 @@ """Demonstrates createCallback mixed with steps, waits, and other operations.""" -import time from typing import Any from aws_durable_execution_sdk_python.config import CallbackConfig, Duration diff --git a/packages/aws-durable-execution-sdk-python-examples/src/callback/callback_serdes.py b/packages/aws-durable-execution-sdk-python-examples/src/callback/callback_serdes.py index c624a79..0b7cfed 100644 --- a/packages/aws-durable-execution-sdk-python-examples/src/callback/callback_serdes.py +++ b/packages/aws-durable-execution-sdk-python-examples/src/callback/callback_serdes.py @@ -1,7 +1,7 @@ """Demonstrates createCallback with custom serialization/deserialization for Date objects.""" import json -from datetime import datetime, timezone +from datetime import datetime from typing import Any, Optional from aws_durable_execution_sdk_python.config import CallbackConfig, Duration diff --git a/packages/aws-durable-execution-sdk-python-examples/src/filesystem_serdes/filesystem_serdes_basic.py b/packages/aws-durable-execution-sdk-python-examples/src/filesystem_serdes/filesystem_serdes_basic.py index 6f8a49b..0a08056 100644 --- a/packages/aws-durable-execution-sdk-python-examples/src/filesystem_serdes/filesystem_serdes_basic.py +++ b/packages/aws-durable-execution-sdk-python-examples/src/filesystem_serdes/filesystem_serdes_basic.py @@ -18,8 +18,6 @@ from aws_durable_execution_sdk_python.context import DurableContext from aws_durable_execution_sdk_python.execution import durable_execution from aws_durable_execution_sdk_python.filesystem_serdes import ( - FileSystemSerDesConfig, - FileSystemSerDesMode, FileSystemSerDes, ) diff --git a/packages/aws-durable-execution-sdk-python-examples/src/map/map_completion.py b/packages/aws-durable-execution-sdk-python-examples/src/map/map_completion.py index 02db238..7c03e88 100644 --- a/packages/aws-durable-execution-sdk-python-examples/src/map/map_completion.py +++ b/packages/aws-durable-execution-sdk-python-examples/src/map/map_completion.py @@ -35,7 +35,7 @@ def handler(_event: Any, context: DurableContext) -> dict[str, Any]: ) context.logger.info( - f"Starting map with config: min_successful=2, tolerated_failure_percentage=50" + "Starting map with config: min_successful=2, tolerated_failure_percentage=50" ) context.logger.info( f"Items pattern: {', '.join(['FAIL' if i['shouldFail'] else 'SUCCESS' for i in items])}" diff --git a/packages/aws-durable-execution-sdk-python-examples/src/wait_for_callback/wait_for_callback_serdes.py b/packages/aws-durable-execution-sdk-python-examples/src/wait_for_callback/wait_for_callback_serdes.py index d3e7259..6d71108 100644 --- a/packages/aws-durable-execution-sdk-python-examples/src/wait_for_callback/wait_for_callback_serdes.py +++ b/packages/aws-durable-execution-sdk-python-examples/src/wait_for_callback/wait_for_callback_serdes.py @@ -2,7 +2,7 @@ import json from datetime import datetime -from typing import Any, Optional, TypedDict +from typing import Any, TypedDict from aws_durable_execution_sdk_python.config import Duration, WaitForCallbackConfig from aws_durable_execution_sdk_python.context import DurableContext diff --git a/packages/aws-durable-execution-sdk-python-examples/src/wait_for_callback/wait_for_callback_submitter_failure.py b/packages/aws-durable-execution-sdk-python-examples/src/wait_for_callback/wait_for_callback_submitter_failure.py index ab46066..b1a854f 100644 --- a/packages/aws-durable-execution-sdk-python-examples/src/wait_for_callback/wait_for_callback_submitter_failure.py +++ b/packages/aws-durable-execution-sdk-python-examples/src/wait_for_callback/wait_for_callback_submitter_failure.py @@ -32,7 +32,7 @@ def submitter(callback_id: str, _context) -> None: ), ) - result: str = context.wait_for_callback( + context.wait_for_callback( submitter, name="retry-submitter-callback", config=config, diff --git a/packages/aws-durable-execution-sdk-python-examples/test/callback/test_callback_mixed_ops.py b/packages/aws-durable-execution-sdk-python-examples/test/callback/test_callback_mixed_ops.py index f87c06c..803f169 100644 --- a/packages/aws-durable-execution-sdk-python-examples/test/callback/test_callback_mixed_ops.py +++ b/packages/aws-durable-execution-sdk-python-examples/test/callback/test_callback_mixed_ops.py @@ -1,7 +1,6 @@ """Tests for create_callback_mixed_ops.""" import json -import time import pytest from aws_durable_execution_sdk_python.execution import InvocationStatus diff --git a/packages/aws-durable-execution-sdk-python-examples/test/callback/test_callback_serdes.py b/packages/aws-durable-execution-sdk-python-examples/test/callback/test_callback_serdes.py index b007782..e59c861 100644 --- a/packages/aws-durable-execution-sdk-python-examples/test/callback/test_callback_serdes.py +++ b/packages/aws-durable-execution-sdk-python-examples/test/callback/test_callback_serdes.py @@ -1,6 +1,5 @@ """Tests for create_callback_serdes.""" -import json from datetime import datetime, timezone import pytest diff --git a/packages/aws-durable-execution-sdk-python-examples/test/map/test_map_operations.py b/packages/aws-durable-execution-sdk-python-examples/test/map/test_map_operations.py index da8dc93..912c9e6 100644 --- a/packages/aws-durable-execution-sdk-python-examples/test/map/test_map_operations.py +++ b/packages/aws-durable-execution-sdk-python-examples/test/map/test_map_operations.py @@ -4,7 +4,6 @@ from aws_durable_execution_sdk_python.execution import InvocationStatus from aws_durable_execution_sdk_python.lambda_service import ( OperationStatus, - OperationType, ) from src.map import map_operations diff --git a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_multiple_invocations.py b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_multiple_invocations.py index 8c297dc..119f262 100644 --- a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_multiple_invocations.py +++ b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_multiple_invocations.py @@ -1,7 +1,6 @@ """Tests for wait_for_callback_multiple_invocations.""" import json -import time import pytest from aws_durable_execution_sdk_python.execution import InvocationStatus diff --git a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_serdes.py b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_serdes.py index 1333f88..79efead 100644 --- a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_serdes.py +++ b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_serdes.py @@ -1,6 +1,5 @@ """Tests for wait_for_callback_serdes.""" -import json from datetime import datetime, timezone import pytest diff --git a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_submitter_failure.py b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_submitter_failure.py index e4463c8..6759aef 100644 --- a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_submitter_failure.py +++ b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_submitter_failure.py @@ -1,7 +1,5 @@ """Tests for wait_for_callback_submitter_retry_success.""" -import json - import pytest from aws_durable_execution_sdk_python.execution import InvocationStatus diff --git a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_submitter_failure_catchable.py b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_submitter_failure_catchable.py index b3458d0..4e18894 100644 --- a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_submitter_failure_catchable.py +++ b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_callback/test_wait_for_callback_submitter_failure_catchable.py @@ -1,7 +1,6 @@ """Tests for wait_for_callback_failing_submitter.""" import pytest -from aws_durable_execution_sdk_python.execution import InvocationStatus from src.wait_for_callback import wait_for_callback_submitter_failure_catchable from test.conftest import deserialize_operation_payload diff --git a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_condition/test_wait_for_condition.py b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_condition/test_wait_for_condition.py index 589ca37..51e453a 100644 --- a/packages/aws-durable-execution-sdk-python-examples/test/wait_for_condition/test_wait_for_condition.py +++ b/packages/aws-durable-execution-sdk-python-examples/test/wait_for_condition/test_wait_for_condition.py @@ -1,10 +1,8 @@ """Tests for wait_for_condition.""" import pytest -from aws_durable_execution_sdk_python.execution import InvocationStatus from src.wait_for_condition import wait_for_condition -from test.conftest import deserialize_operation_payload @pytest.mark.example diff --git a/packages/aws-durable-execution-sdk-python-otel/pyproject.toml b/packages/aws-durable-execution-sdk-python-otel/pyproject.toml index 500880e..a4f93c6 100644 --- a/packages/aws-durable-execution-sdk-python-otel/pyproject.toml +++ b/packages/aws-durable-execution-sdk-python-otel/pyproject.toml @@ -72,7 +72,7 @@ target-version = "py311" [tool.ruff.lint] preview = true -select = ["TID252"] +select = ["F", "TID252"] # Pyflakes (unused imports, undefined names, etc.) + absolute imports [tool.ruff.lint.isort] known-first-party = ["aws_durable_execution_sdk_python_otel"] diff --git a/packages/aws-durable-execution-sdk-python-otel/tests/test_deterministic_id_generator.py b/packages/aws-durable-execution-sdk-python-otel/tests/test_deterministic_id_generator.py index 6e72517..15990ff 100644 --- a/packages/aws-durable-execution-sdk-python-otel/tests/test_deterministic_id_generator.py +++ b/packages/aws-durable-execution-sdk-python-otel/tests/test_deterministic_id_generator.py @@ -9,7 +9,6 @@ from opentelemetry.sdk.trace import IdGenerator, RandomIdGenerator from aws_durable_execution_sdk_python_otel.deterministic_id_generator import ( - HASHED_ID_PATTERN, DeterministicIdGenerator, _parse_xray_root_trace_id, _to_otel_trace_id, diff --git a/packages/aws-durable-execution-sdk-python-testing/pyproject.toml b/packages/aws-durable-execution-sdk-python-testing/pyproject.toml index 559e6fa..ee098da 100644 --- a/packages/aws-durable-execution-sdk-python-testing/pyproject.toml +++ b/packages/aws-durable-execution-sdk-python-testing/pyproject.toml @@ -105,7 +105,7 @@ target-version = "py311" [tool.ruff.lint] preview = false -select = ["TID252"] # Enforce absolute imports (ban relative imports) +select = ["F", "TID252"] # Pyflakes (unused imports, undefined names, etc.) + absolute imports [tool.ruff.lint.isort] known-first-party = ["aws_durable_execution_sdk_python_testing"] diff --git a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/cli.py b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/cli.py index 85dcb7d..684c496 100644 --- a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/cli.py +++ b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/cli.py @@ -19,7 +19,6 @@ from typing import Any from urllib.parse import urljoin -import aws_durable_execution_sdk_python import boto3 # type: ignore from urllib.error import HTTPError, URLError from urllib.request import Request, urlopen diff --git a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/executor.py b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/executor.py index 02a1504..dc4ecfa 100644 --- a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/executor.py +++ b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/executor.py @@ -3,7 +3,6 @@ from __future__ import annotations import logging -import time import uuid from datetime import UTC, datetime from typing import TYPE_CHECKING @@ -24,7 +23,6 @@ ) from aws_durable_execution_sdk_python_testing.exceptions import ( - ExecutionAlreadyStartedException, IllegalStateException, InvalidParameterValueException, ResourceNotFoundException, @@ -34,7 +32,6 @@ CheckpointDurableExecutionResponse, CheckpointUpdatedExecutionState, EventCreationContext, - EventType, GetDurableExecutionHistoryResponse, GetDurableExecutionResponse, GetDurableExecutionStateResponse, diff --git a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/runner.py b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/runner.py index d60e774..1023e2e 100644 --- a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/runner.py +++ b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/runner.py @@ -2,7 +2,6 @@ import json import logging -import os import time from dataclasses import dataclass, field from typing import ( @@ -16,7 +15,6 @@ cast, ) -import aws_durable_execution_sdk_python import boto3 # type: ignore from botocore.exceptions import ClientError # type: ignore from aws_durable_execution_sdk_python.execution import ( @@ -688,7 +686,7 @@ def wait_for_callback( ) if callback_id: return callback_id - except ResourceNotFoundException as e: + except ResourceNotFoundException: pass except Exception as e: msg = f"Failed to fetch execution history: {e}" diff --git a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/web/handlers.py b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/web/handlers.py index e8cb841..a1fe093 100644 --- a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/web/handlers.py +++ b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/web/handlers.py @@ -2,7 +2,6 @@ from __future__ import annotations -import base64 import json import logging from abc import ABC, abstractmethod @@ -26,7 +25,6 @@ ListDurableExecutionsResponse, SendDurableExecutionCallbackFailureRequest, SendDurableExecutionCallbackFailureResponse, - SendDurableExecutionCallbackHeartbeatRequest, SendDurableExecutionCallbackHeartbeatResponse, SendDurableExecutionCallbackSuccessResponse, StartDurableExecutionInput, diff --git a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/web/serialization.py b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/web/serialization.py index 6532a66..70caf35 100644 --- a/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/web/serialization.py +++ b/packages/aws-durable-execution-sdk-python-testing/src/aws_durable_execution_sdk_python_testing/web/serialization.py @@ -7,11 +7,10 @@ from __future__ import annotations import json -import os +import os # noqa: F401 - accessed via module namespace in tests (mock.patch) from typing import Any, Protocol from datetime import datetime -import aws_durable_execution_sdk_python import botocore.loaders # type: ignore from botocore.model import ServiceModel # type: ignore from botocore.parsers import create_parser # type: ignore diff --git a/packages/aws-durable-execution-sdk-python-testing/tests/executor_test.py b/packages/aws-durable-execution-sdk-python-testing/tests/executor_test.py index e228a0d..91e6e9c 100644 --- a/packages/aws-durable-execution-sdk-python-testing/tests/executor_test.py +++ b/packages/aws-durable-execution-sdk-python-testing/tests/executor_test.py @@ -24,7 +24,6 @@ ExecutionDetails, ) from aws_durable_execution_sdk_python_testing.exceptions import ( - ExecutionAlreadyStartedException, IllegalStateException, InvalidParameterValueException, ResourceNotFoundException, diff --git a/packages/aws-durable-execution-sdk-python-testing/tests/invoker_test.py b/packages/aws-durable-execution-sdk-python-testing/tests/invoker_test.py index 1270f50..3ba9837 100644 --- a/packages/aws-durable-execution-sdk-python-testing/tests/invoker_test.py +++ b/packages/aws-durable-execution-sdk-python-testing/tests/invoker_test.py @@ -26,7 +26,6 @@ InProcessInvoker, LambdaInvoker, _LAMBDA_CLIENT_CONFIG, - create_lambda_client, create_test_lambda_context, ) from aws_durable_execution_sdk_python_testing.model import ( diff --git a/packages/aws-durable-execution-sdk-python-testing/tests/runner_test.py b/packages/aws-durable-execution-sdk-python-testing/tests/runner_test.py index 3b81269..b423ec9 100644 --- a/packages/aws-durable-execution-sdk-python-testing/tests/runner_test.py +++ b/packages/aws-durable-execution-sdk-python-testing/tests/runner_test.py @@ -1319,9 +1319,6 @@ def test_cloud_runner_run_bad_status_code(mock_boto3): @patch("aws_durable_execution_sdk_python_testing.runner.boto3") def test_cloud_runner_run_function_error(mock_boto3): """Test DurableFunctionCloudTestRunner.run with function error.""" - from aws_durable_execution_sdk_python_testing.exceptions import ( - DurableFunctionsTestError, - ) from aws_durable_execution_sdk_python_testing.runner import ( DurableFunctionCloudTestRunner, ) @@ -1412,8 +1409,6 @@ def test_durable_function_test_result_from_execution_history_filters_execution_t """Test from_execution_history filters out EXECUTION type operations.""" import datetime - from aws_durable_execution_sdk_python.execution import InvocationStatus - from aws_durable_execution_sdk_python_testing.model import ( Event, GetDurableExecutionHistoryResponse, @@ -1485,8 +1480,6 @@ def test_durable_function_test_result_from_execution_history_with_parent_operati """Test from_execution_history filters operations with parent_id.""" import datetime - from aws_durable_execution_sdk_python.execution import InvocationStatus - from aws_durable_execution_sdk_python_testing.model import ( Event, GetDurableExecutionHistoryResponse, diff --git a/packages/aws-durable-execution-sdk-python-testing/tests/stores/filesystem_store_test.py b/packages/aws-durable-execution-sdk-python-testing/tests/stores/filesystem_store_test.py index 01da777..260d0fa 100644 --- a/packages/aws-durable-execution-sdk-python-testing/tests/stores/filesystem_store_test.py +++ b/packages/aws-durable-execution-sdk-python-testing/tests/stores/filesystem_store_test.py @@ -14,8 +14,6 @@ FileSystemExecutionStore, ) -from datetime import datetime, timezone - @pytest.fixture def temp_storage_dir(): diff --git a/packages/aws-durable-execution-sdk-python-testing/tests/web/handlers_test.py b/packages/aws-durable-execution-sdk-python-testing/tests/web/handlers_test.py index 3cb84a8..3b5d193 100644 --- a/packages/aws-durable-execution-sdk-python-testing/tests/web/handlers_test.py +++ b/packages/aws-durable-execution-sdk-python-testing/tests/web/handlers_test.py @@ -2,8 +2,6 @@ from __future__ import annotations -import base64 -import json from typing import TYPE_CHECKING, Any from unittest.mock import Mock diff --git a/packages/aws-durable-execution-sdk-python-testing/tests/web/models_test.py b/packages/aws-durable-execution-sdk-python-testing/tests/web/models_test.py index 8148736..f64594c 100644 --- a/packages/aws-durable-execution-sdk-python-testing/tests/web/models_test.py +++ b/packages/aws-durable-execution-sdk-python-testing/tests/web/models_test.py @@ -2,7 +2,6 @@ from __future__ import annotations -import datetime import json from unittest.mock import Mock, patch diff --git a/packages/aws-durable-execution-sdk-python/pyproject.toml b/packages/aws-durable-execution-sdk-python/pyproject.toml index 62e8076..9ba503f 100644 --- a/packages/aws-durable-execution-sdk-python/pyproject.toml +++ b/packages/aws-durable-execution-sdk-python/pyproject.toml @@ -63,7 +63,7 @@ target-version = "py311" [tool.ruff.lint] preview = true -select = ["TID252"] # Enforce absolute imports (ban relative imports) +select = ["F", "TID252"] # Pyflakes (unused imports, undefined names, etc.) + absolute imports [tool.ruff.lint.isort] known-first-party = ["aws_durable_execution_sdk_python"] diff --git a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/concurrency/executor.py b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/concurrency/executor.py index 0cdf40e..b8fef24 100644 --- a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/concurrency/executor.py +++ b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/concurrency/executor.py @@ -30,7 +30,7 @@ TimedSuspendExecution, ) from aws_durable_execution_sdk_python.identifier import OperationIdentifier -from aws_durable_execution_sdk_python.lambda_service import ErrorObject, OperationType +from aws_durable_execution_sdk_python.lambda_service import ErrorObject from aws_durable_execution_sdk_python.operation.child import child_handler diff --git a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/context.py b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/context.py index c2e1d32..ce314fb 100644 --- a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/context.py +++ b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/context.py @@ -25,7 +25,6 @@ from aws_durable_execution_sdk_python.identifier import OperationIdentifier from aws_durable_execution_sdk_python.lambda_service import ( OperationSubType, - OperationType, ) from aws_durable_execution_sdk_python.logger import Logger, LogInfo from aws_durable_execution_sdk_python.operation.callback import ( diff --git a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/execution.py b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/execution.py index e564764..ac537c0 100644 --- a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/execution.py +++ b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/execution.py @@ -14,7 +14,6 @@ BackgroundThreadError, BotoClientError, CheckpointError, - DurableExecutionsError, ExecutionError, InvocationError, SuspendExecution, @@ -26,7 +25,6 @@ InvocationStatus, LambdaClient, Operation, - OperationType, OperationUpdate, ) from aws_durable_execution_sdk_python.plugin import ( diff --git a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/filesystem_serdes.py b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/filesystem_serdes.py index d60f448..d1561c3 100644 --- a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/filesystem_serdes.py +++ b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/filesystem_serdes.py @@ -29,7 +29,6 @@ from urllib.parse import quote from aws_durable_execution_sdk_python.constants import CHECKPOINT_SIZE_LIMIT_BYTES -from aws_durable_execution_sdk_python.preview import build_preview from aws_durable_execution_sdk_python.serdes import ( EXTENDED_TYPES_SERDES, SerDes, diff --git a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/step.py b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/step.py index 35ae2d1..02f62d9 100644 --- a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/step.py +++ b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/step.py @@ -13,19 +13,16 @@ ExecutionError, InvalidStateError, StepInterruptedError, - SuspendExecution, ) from aws_durable_execution_sdk_python.lambda_service import ( ErrorObject, OperationUpdate, - OperationType, ) from aws_durable_execution_sdk_python.logger import Logger, LogInfo from aws_durable_execution_sdk_python.operation.base import ( CheckResult, OperationExecutor, ) -from aws_durable_execution_sdk_python.plugin import UserFunctionStartInfo from aws_durable_execution_sdk_python.retries import RetryDecision, RetryPresets from aws_durable_execution_sdk_python.serdes import deserialize, serialize from aws_durable_execution_sdk_python.suspend import ( diff --git a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/wait_for_condition.py b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/wait_for_condition.py index a53d8ef..8771de3 100644 --- a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/wait_for_condition.py +++ b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/wait_for_condition.py @@ -11,8 +11,6 @@ from aws_durable_execution_sdk_python.lambda_service import ( ErrorObject, OperationUpdate, - OperationType, - OperationSubType, ) from aws_durable_execution_sdk_python.logger import LogInfo from aws_durable_execution_sdk_python.operation.base import ( diff --git a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/state.py b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/state.py index 9996591..c6a044d 100644 --- a/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/state.py +++ b/packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/state.py @@ -11,7 +11,7 @@ from dataclasses import dataclass from enum import Enum from threading import Lock -from typing import TYPE_CHECKING, Callable, Any +from typing import TYPE_CHECKING, Callable from aws_durable_execution_sdk_python.exceptions import ( BackgroundThreadError, @@ -32,11 +32,9 @@ OperationType, OperationUpdate, StateOutput, - OperationSubType, ) from aws_durable_execution_sdk_python.plugin import ( PluginExecutor, - UserFunctionStartInfo, ) from aws_durable_execution_sdk_python.threading import CompletionEvent, OrderedLock diff --git a/packages/aws-durable-execution-sdk-python/tests/concurrency_test.py b/packages/aws-durable-execution-sdk-python/tests/concurrency_test.py index 1bfa631..846afbe 100644 --- a/packages/aws-durable-execution-sdk-python/tests/concurrency_test.py +++ b/packages/aws-durable-execution-sdk-python/tests/concurrency_test.py @@ -41,10 +41,8 @@ SuspendExecution, TimedSuspendExecution, ) -from aws_durable_execution_sdk_python.identifier import OperationIdentifier from aws_durable_execution_sdk_python.lambda_service import ( ErrorObject, - OperationSubType, ) from aws_durable_execution_sdk_python.operation.map import MapExecutor diff --git a/packages/aws-durable-execution-sdk-python/tests/e2e/checkpoint_response_int_test.py b/packages/aws-durable-execution-sdk-python/tests/e2e/checkpoint_response_int_test.py index de168af..66c9ad5 100644 --- a/packages/aws-durable-execution-sdk-python/tests/e2e/checkpoint_response_int_test.py +++ b/packages/aws-durable-execution-sdk-python/tests/e2e/checkpoint_response_int_test.py @@ -28,7 +28,7 @@ ) if TYPE_CHECKING: - from aws_durable_execution_sdk_python.types import StepContext, LambdaContext + from aws_durable_execution_sdk_python.types import StepContext def create_mock_checkpoint_with_operations(): diff --git a/packages/aws-durable-execution-sdk-python/tests/e2e/filesystem_serdes_int_test.py b/packages/aws-durable-execution-sdk-python/tests/e2e/filesystem_serdes_int_test.py index 46d7be9..08f1fa4 100644 --- a/packages/aws-durable-execution-sdk-python/tests/e2e/filesystem_serdes_int_test.py +++ b/packages/aws-durable-execution-sdk-python/tests/e2e/filesystem_serdes_int_test.py @@ -5,17 +5,13 @@ - Replay: step deserializes from checkpointed envelope, reads from filesystem """ -from __future__ import annotations - import json import os -from typing import TYPE_CHECKING, Any +from typing import Any from unittest.mock import Mock, patch -import pytest - from aws_durable_execution_sdk_python.config import StepConfig -from aws_durable_execution_sdk_python.context import DurableContext, durable_step +from aws_durable_execution_sdk_python.context import DurableContext from aws_durable_execution_sdk_python.execution import ( InvocationStatus, durable_execution, @@ -36,16 +32,9 @@ from aws_durable_execution_sdk_python.lambda_service import ( CheckpointOutput, CheckpointUpdatedExecutionState, - Operation, OperationAction, - OperationStatus, - OperationType, - StepDetails, ) -if TYPE_CHECKING: - from aws_durable_execution_sdk_python.types import StepContext - def _create_lambda_context(): """Create a mock Lambda context.""" @@ -185,7 +174,6 @@ def test_filesystem_serdes_replay_from_checkpoint(tmp_path): step_id = next(operation_id_sequence()) # Pre-create the file that would have been written in the first invocation - arn = "arn:aws:lambda:us-east-1:123456789012:function:test-func:1/durable-execution/exec-001/inv-001" dir_path = os.path.join(mount_path, "test-func", "exec-001", "inv-001") os.makedirs(dir_path, exist_ok=True) diff --git a/packages/aws-durable-execution-sdk-python/tests/filesystem_serdes_test.py b/packages/aws-durable-execution-sdk-python/tests/filesystem_serdes_test.py index dcc800d..61c8b37 100644 --- a/packages/aws-durable-execution-sdk-python/tests/filesystem_serdes_test.py +++ b/packages/aws-durable-execution-sdk-python/tests/filesystem_serdes_test.py @@ -10,7 +10,6 @@ FileSystemPathEncoding, FileSystemSerDesConfig, FileSystemSerDesMode, - _OVERFLOW_THRESHOLD_BYTES, _encode_segment, _resolve_execution_dir, _write_to_file, diff --git a/pyproject.toml b/pyproject.toml index 6bca74e..5099a53 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -172,7 +172,7 @@ exclude = [".github/scripts/*.sh", ".github/workflows"] [tool.ruff.lint] preview = true -select = ["TID252"] # Enforce absolute imports (ban relative imports) +select = ["F", "TID252"] # Pyflakes (unused imports, undefined names, etc.) + absolute imports [tool.ruff.lint.isort] known-first-party = [