From 80fdf46940b8bad87f2b6c829b1ddba21415bf6f Mon Sep 17 00:00:00 2001 From: Fabian Wiesel Date: Thu, 9 Jul 2026 10:29:44 +0200 Subject: [PATCH 1/2] Regenerate with controller-gen v0.21.0 and fix API doc typos CI installs controller-gen@latest which is now v0.21.0. The new version correctly omits the namespace parameter from apply configuration constructors for cluster-scoped resources (Hypervisor, Eviction). Also fixes grammatical errors in API type comments that propagate into CRD schema descriptions: - "request an reboot" -> "requests a reboot" - "request an evacuation" -> "requests an evacuation" - "Require to issue" -> "Requires issuing" - "enable the installations" -> "enable the installation" - "the take the following" -> "take the following" - "Represent the num of instances" -> "Represents the number of instances" --- api/v1/hypervisor_types.go | 14 +- applyconfigurations/api/v1/aggregate.go | 9 +- applyconfigurations/api/v1/aggregategroup.go | 3 + applyconfigurations/api/v1/capabilities.go | 11 +- applyconfigurations/api/v1/cell.go | 24 +- .../api/v1/domaincapabilities.go | 44 +- applyconfigurations/api/v1/eviction.go | 49 +- applyconfigurations/api/v1/evictionspec.go | 6 +- applyconfigurations/api/v1/evictionstatus.go | 11 +- applyconfigurations/api/v1/group.go | 7 + applyconfigurations/api/v1/hypervisor.go | 49 +- applyconfigurations/api/v1/hypervisorspec.go | 76 ++- .../api/v1/hypervisorstatus.go | 75 ++- .../api/v1/hypervisorupdatestatus.go | 9 +- applyconfigurations/api/v1/instance.go | 9 +- .../api/v1/operatingsystemstatus.go | 45 +- applyconfigurations/api/v1/traitgroup.go | 3 + applyconfigurations/internal/internal.go | 577 ++++++++++++++++++ .../crds/kvm.cloud.sap_evictions.yaml | 2 +- .../crds/kvm.cloud.sap_hypervisors.yaml | 16 +- 20 files changed, 947 insertions(+), 92 deletions(-) diff --git a/api/v1/hypervisor_types.go b/api/v1/hypervisor_types.go index 9a78b4d0..f4d2d23f 100644 --- a/api/v1/hypervisor_types.go +++ b/api/v1/hypervisor_types.go @@ -115,11 +115,11 @@ type HypervisorSpec struct { OperatingSystemVersion string `json:"version,omitempty"` // +kubebuilder:default:=false - // Reboot request an reboot after successful installation of an upgrade. + // Reboot requests a reboot after successful installation of an upgrade. Reboot bool `json:"reboot"` // +kubebuilder:default:=true - // EvacuateOnReboot request an evacuation of all instances before reboot. + // EvacuateOnReboot requests an evacuation of all instances before reboot. EvacuateOnReboot bool `json:"evacuateOnReboot"` // +kubebuilder:default:=true @@ -168,12 +168,12 @@ type HypervisorSpec struct { HighAvailability bool `json:"highAvailability"` // +kubebuilder:default:=false - // Require to issue a certificate from cert-manager for the hypervisor, to be used for + // Requires issuing a certificate from cert-manager for the hypervisor, to be used for // secure communication with the libvirt API. CreateCertManagerCertificate bool `json:"createCertManagerCertificate"` // +kubebuilder:default:=true - // InstallCertificate is used to enable the installations of the certificates via kvm-node-agent. + // InstallCertificate is used to enable the installation of the certificates via kvm-node-agent. InstallCertificate bool `json:"installCertificate"` // +kubebuilder:optional @@ -401,7 +401,7 @@ type DomainCapabilities struct { // Supported devices for domains. // // The format of this list is the device type, and if specified, a specific - // model. For example, the take the following xml domain device definition: + // model. For example, take the following xml domain device definition: // //