robustness: improve error handling for NewTestReport

Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>

Author: henrybear327

tests/antithesis/test-template/robustness/traffic/main.go

@@ -76,7 +76,10 @@ func main() {
 	choice := rand.IntN(len(traffics))
 	tf := traffics[choice]
 	lg.Info("Traffic", zap.String("Type", trafficNames[choice]))
-	r := report.NewTestReport(lg, reportPath, etcdetcdDataPaths, &report.TrafficDetail{ExpectUniqueRevision: tf.ExpectUniqueRevision()})
+	r, err := report.NewTestReport(lg, reportPath, etcdetcdDataPaths, &report.TrafficDetail{ExpectUniqueRevision: tf.ExpectUniqueRevision()})
+	if err != nil {
+		lg.Fatal("Failed to create test report", zap.Error(err))
+	}
 	defer func() {
 		if err = r.SaveEtcdData(); err != nil {
 			lg.Error("Failed to save traffic generation report", zap.Error(err))

tests/robustness/main_test.go

@@ -88,7 +88,8 @@ func TestRobustnessRegression(t *testing.T) {
 }
 
 func testRobustness(ctx context.Context, t *testing.T, lg *zap.Logger, s scenarios.TestScenario, c *e2e.EtcdProcessCluster) {
-	r := report.NewTestReport(lg, testResultsDirectory(t), report.ServerDataPaths(c), &report.TrafficDetail{ExpectUniqueRevision: s.Traffic.ExpectUniqueRevision()})
+	r, err := report.NewTestReport(lg, testResultsDirectory(t), report.ServerDataPaths(c), &report.TrafficDetail{ExpectUniqueRevision: s.Traffic.ExpectUniqueRevision()})
+	require.NoError(t, err)
 	// t.Failed() returns false during panicking. We need to forcibly
 	// save data on panicking.
 	// Refer to: https://github.com/golang/go/issues/49929

tests/robustness/report/report.go

@@ -36,16 +36,16 @@ type TestReport struct {
 	dataSaved       bool
 }
 
-func NewTestReport(lg *zap.Logger, reportPath string, serverDataPaths map[string]string, traffic *TrafficDetail) *TestReport {
+func NewTestReport(lg *zap.Logger, reportPath string, serverDataPaths map[string]string, traffic *TrafficDetail) (*TestReport, error) {
 	if reportPath == "" {
-		panic("reportPath is not set")
+		return nil, fmt.Errorf("reportPath is not set")
 	}
 	return &TestReport{
 		logger:          lg,
 		reportPath:      reportPath,
 		serverDataPaths: serverDataPaths,
 		traffic:         traffic,
-	}
+	}, nil
 }
 
 func (r *TestReport) SetClientReports(reports []ClientReport) {