Skip to content

chore: bring back dev replaces#3347

Merged
julienrbrt merged 1 commit into
mainfrom
julien/dev
Jun 8, 2026
Merged

chore: bring back dev replaces#3347
julienrbrt merged 1 commit into
mainfrom
julien/dev

Conversation

@julienrbrt

@julienrbrt julienrbrt commented Jun 8, 2026

Copy link
Copy Markdown
Member

Overview

Summary by CodeRabbit

  • Chores
    • Updated module dependency resolution configuration to use local workspace paths instead of published module versions across the EVM, gRPC, and test applications.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR activates replace directives in three app module files to redirect dependency resolution for github.com/evstack/ev-node and its execution submodules to local relative paths, enabling development workflow where all modules reference the local workspace version instead of published package versions.

Changes

Local module replacement configuration

Layer / File(s) Summary
Enable local path resolution for ev-node modules
apps/evm/go.mod, apps/grpc/go.mod, apps/testapp/go.mod
The previously commented-out replace directives are activated across three app modules. apps/evm/go.mod and apps/grpc/go.mod enable local resolution for github.com/evstack/ev-node and their respective execution submodules (execution/evm and execution/grpc). apps/testapp/go.mod adds a single replace directive for github.com/evstack/ev-node pointing to the local workspace.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • evstack/ev-node#3232: Both PRs activate development replace directives in apps/evm/go.mod (and apps/testapp/go.mod) to map github.com/evstack/ev-node and related execution modules to local relative paths for module resolution.
  • evstack/ev-node#3144: Both PRs modify the go.mod module-resolution for github.com/evstack/ev-node by changing replace directives and/or local-path resolution in the apps/* (notably apps/evm and apps/grpc) go.mod files, so the changes overlap at the dependency wiring level.
  • evstack/ev-node#3276: The main PR and retrieved PR both re-enable/activate the same go.mod replace directives to map github.com/evstack/ev-node (and specific execution submodules) to local ../../ paths across apps/evm, apps/grpc, and apps/testapp.

Suggested reviewers

  • tac0turtle
  • chatton

Poem

🐰 Local paths now lead the way,
Three modules dance together in play,
Replace directives, no longer asleep,
Dev workflows happy, development's deep.
A workspace united, cohesive and bright!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty, containing only the template structure with no actual content in the Overview section or any linked issues. Fill in the Overview section with context, background, goal, and rationale for reactivating the dev replaces, or provide a link to a related issue.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: bring back dev replaces' clearly summarizes the main change: reactivating previously commented-out replace directives in Go module files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julien/dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJun 8, 2026, 3:49 PM

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
apps/testapp/go.mod (1)

5-5: ⚡ Quick win

Remove trailing dot for consistency.

The path uses ../../. whereas apps/evm/go.mod and apps/grpc/go.mod use ../../. The trailing dot is unnecessary and creates inconsistency across the workspace's replace directives.

📝 Suggested fix
-replace github.com/evstack/ev-node => ../../.
+replace github.com/evstack/ev-node => ../../
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/testapp/go.mod` at line 5, The replace directive "replace
github.com/evstack/ev-node => ../../." includes an unnecessary trailing dot;
update the replace target to use "../../" (matching the style used in other
go.mod files like the ones referencing ../../) by removing the trailing dot from
the replace RHS so the directive becomes a direct folder path without the
trailing period.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@apps/testapp/go.mod`:
- Line 5: The replace directive "replace github.com/evstack/ev-node => ../../."
includes an unnecessary trailing dot; update the replace target to use "../../"
(matching the style used in other go.mod files like the ones referencing ../../)
by removing the trailing dot from the replace RHS so the directive becomes a
direct folder path without the trailing period.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a067bb59-f37d-4094-9cd3-57da4e305961

📥 Commits

Reviewing files that changed from the base of the PR and between 056bf5a and 9944f20.

⛔ Files ignored due to path filters (3)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/grpc/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod

@claude

claude Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @julienrbrt's task in 1m 11s —— View job


Code Review

  • Gather context
  • Read changed files
  • Analyze replace directives for correctness and consistency
  • Post review feedback

This is a straightforward dev-workflow maintenance PR that uncomments the replace directives to re-enable local module resolution across three app modules. The pattern follows the repo's established cycle: comment out replaces before publishing a version bump, then bring them back for continued development.

Overall: LGTM with one minor nit.

Correctness

The replace directives are correctly scoped:

  • apps/evm/go.mod: replaces both ev-node and execution/evm — correct, both are required (execution/evm is a direct dep with its own go.mod).
  • apps/grpc/go.mod: replaces both ev-node and execution/grpc — correct, same reasoning.
  • apps/testapp/go.mod: replaces only ev-node — correct, testapp has no direct execution sub-module dependency.

None of the files attempt to replace ev-node/core, which is also correct since core is a separately published module that's only consumed, not developed, in this cycle.

One Nit: Trailing dot in apps/testapp/go.mod

apps/testapp/go.mod line 5:

// current (inconsistent)
replace github.com/evstack/ev-node => ../../.

// should match the other files
replace github.com/evstack/ev-node => ../../

Both resolve identically (Go normalizes the path), but the trailing . was already there in the commented-out version and should be cleaned up to match apps/evm and apps/grpc. Fix this →

Note on merging dev replaces to main

This appears to be an intentional workflow where main stays in "dev mode" with local replaces active, and they get commented out right before a release tag. As long as this is an established convention in the repo (prior art: PRs #3276, #3232), it's fine. Just worth ensuring CI enforces that replaces are absent in any release-tagged commits.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.72%. Comparing base (056bf5a) to head (9944f20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3347      +/-   ##
==========================================
- Coverage   60.73%   60.72%   -0.01%     
==========================================
  Files         127      127              
  Lines       13781    13781              
==========================================
- Hits         8370     8369       -1     
- Misses       4499     4500       +1     
  Partials      912      912              
Flag Coverage Δ
combined 60.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt merged commit 89c7fe8 into main Jun 8, 2026
32 of 33 checks passed
@julienrbrt julienrbrt deleted the julien/dev branch June 8, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants