chore: bring back dev replaces#3347
Conversation
📝 WalkthroughWalkthroughThis PR activates ChangesLocal module replacement configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/testapp/go.mod (1)
5-5: ⚡ Quick winRemove trailing dot for consistency.
The path uses
../../.whereasapps/evm/go.modandapps/grpc/go.moduse../../. The trailing dot is unnecessary and creates inconsistency across the workspace's replace directives.📝 Suggested fix
-replace github.com/evstack/ev-node => ../../. +replace github.com/evstack/ev-node => ../../🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/testapp/go.mod` at line 5, The replace directive "replace github.com/evstack/ev-node => ../../." includes an unnecessary trailing dot; update the replace target to use "../../" (matching the style used in other go.mod files like the ones referencing ../../) by removing the trailing dot from the replace RHS so the directive becomes a direct folder path without the trailing period.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/testapp/go.mod`:
- Line 5: The replace directive "replace github.com/evstack/ev-node => ../../."
includes an unnecessary trailing dot; update the replace target to use "../../"
(matching the style used in other go.mod files like the ones referencing ../../)
by removing the trailing dot from the replace RHS so the directive becomes a
direct folder path without the trailing period.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a067bb59-f37d-4094-9cd3-57da4e305961
⛔ Files ignored due to path filters (3)
apps/evm/go.sumis excluded by!**/*.sumapps/grpc/go.sumis excluded by!**/*.sumapps/testapp/go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
apps/evm/go.modapps/grpc/go.modapps/testapp/go.mod
|
Claude finished @julienrbrt's task in 1m 11s —— View job Code Review
This is a straightforward dev-workflow maintenance PR that uncomments the Overall: LGTM with one minor nit. CorrectnessThe replace directives are correctly scoped:
None of the files attempt to replace One Nit: Trailing dot in
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3347 +/- ##
==========================================
- Coverage 60.73% 60.72% -0.01%
==========================================
Files 127 127
Lines 13781 13781
==========================================
- Hits 8370 8369 -1
- Misses 4499 4500 +1
Partials 912 912
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Overview
Summary by CodeRabbit