Fix missing catch in clipboard navigation#35
Open
dsimansk wants to merge 1 commit into
Open
Conversation
matejvasek
reviewed
Jun 10, 2026
| btn.classList.add('copied'); | ||
| setTimeout(() => { btn.classList.remove('copied'); }, 1500); | ||
| }); | ||
| }).catch(() => {}); |
Collaborator
There was a problem hiding this comment.
Maybe at least log the error?
Collaborator
There was a problem hiding this comment.
or better yet display some error to user in UI.
twoGiants
requested changes
Jun 10, 2026
twoGiants
left a comment
twoGiants
left a comment
Collaborator
There was a problem hiding this comment.
Keep it up and see my comment below 😸 👍
| btn.classList.add('copied'); | ||
| setTimeout(() => { btn.classList.remove('copied'); }, 1500); | ||
| }); | ||
| }).catch(() => {}); |
Collaborator
There was a problem hiding this comment.
Lets add some error handling here. A visible user message. Something unobtrusive but visible for the user, like the catch in line 245 is doing. But I wouldn't use the same element as in line 245 -> that's the yaml file content area.
Contributor
Author
There was a problem hiding this comment.
ACK, thanks for the hints. It didn't seem right to just ignore the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Per issue description:
@matejvasek is it that simple? :)