Skip to content

npm-only build-release: don't cut a release when nothing new will publish #30

Description

@mairas

In npm-only mode (build-deb: false), the +N revision walks on every main merge, but npm has no +N concept — release.yml publishes the bare VERSION and skips if that version already exists.

So a merge that does not change VERSION still cuts a fresh draft (e.g. v4.8.0+2); when a human publishes it, the npm-exists guard fires and nothing publishes. The GitHub release UI shows a new published release while npm still serves the previous version — a release that looks shipped but isn't.

Mitigated in halos-org/skip#228 with a loud ::warning:: on the skip path + docs, but the draft is still created. Proposal: in npm-only mode, skip pre-release/draft creation (or clearly mark it non-publishing) when the upstream VERSION is unchanged since the last published npm version, so +N-only merges don't produce misleading releases.

Surfaced in the review of halos-org/skip#228 (adversarial, P2).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions