Skip to content

Support for dashes in command names (as was possible in Aloe) #329

Description

@patrickvuarnoz

I'm re-issuing this issue as it was not picked up (maybe not seen) in the leafsphp/auth repository. It's about the following issue: leafsphp/sprout#3

Aloe supported dashes in commands, something like auto-create-reports. Sprout does not support that anymore because of the regexp used to parse the commands.

/src/Sprout/App.php, line 344:

if (!preg_match('/^([\w:]+)(.*?)((?:\{\s*--.*\})+)?$/s', $signature, $matches)) {
    return null;
}

If changed to this it will also support dashes:

if (!preg_match('/^([\w:-]+)(.*?)((?:\{\s*--.*\})+)?$/s', $signature, $matches)) {
    return null;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions