cjs port to mozjs-128

[willysr]

Hi,

is there a plan to move to mozjs 128?
gjs seems to move already
https://gitlab.gnome.org/GNOME/gjs/-/commit/e2ce7205f67feede3dd11e4e10ccf56d545ad647

[Fantu]

There is also an open bug related in Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1081039

[willysr]

I used this patch and it worked
https://github.com/CinnamonSlackBuilds/csb/blob/b6accfbbb3a9f0e3cdba667789d3abe2cf151c6a/cjs/mozjs128.patch

[fulalas]

Although it compiles, when I try to load the actual Cinnamon desktop, it fails to run the panel, muffin, etc. By reverting to no patch and mozjs115 it works straightaway.

[Fantu]

I don't understand exactly what is that big patch without details, seems a rebase, anyway a rebase need to be accurate and can require big amount of time and is very good to specify the exact version (and/or commit) of rebase to make easier check upstream fixes and make faster import them.
Need to check also if in the new version there are important changes that need changes also in cinnamon to adapt to the new version of cjs the first thing to look at is the api changes, you may start to see certain changes from any debug symbols added or removed, but further changes may still be needed.
Also for this reason it is useful to mark the exact version of gjs every rebase, so you can see on gjs the relevant changes between the 2 versions of rebases that require changes to the software that uses it

[clefebvre]

#127

[willysr]

thanks @clefebvre