Clarify error message for private Phabricator revisions#6138
Open
padenot wants to merge 1 commit into
Open
Conversation
Previously, attempting to access a private revision would surface a confusing internal error. Now it raises a ToolError with an explicit message explaining the revision is private or not found. Fixes mozilla#5992
suhaibmujahid
requested changes
Jun 9, 2026
| patch = SanitizedPhabricatorPatch(revision_id=revision_id) | ||
| if not patch.is_public(): | ||
| raise ToolError( | ||
| f"Revision D{revision_id} is private and cannot be accessed." |
Member
There was a problem hiding this comment.
This won’t work since we will always get PhabricatorRevisionNotFoundException on secure revisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, attempting to access a private revision would surface a confusing internal error. Now it raises a
ToolErrorwith an explicit message explaining the revision is private or not found.I'm not entirely certain that it's that useful to distinguish, because our token isn't capable of seeing all revisions, but maybe that will change in the future, and feels right anyway.
Fixes #5992