Include diff ID in review comment#6139
Open
padenot wants to merge 1 commit into
Open
Conversation
Adds a linkified diff reference to the top of the main review comment so reviewers can tell which diff was reviewed at a glance. Fixes mozilla#6029
suhaibmujahid
approved these changes
Jun 8, 2026
| """Create the main review comment that summarizes the review results.""" | ||
| parts = [] | ||
| diff_url = f"{settings.phabricator_url}/D{review_request.revision_id}?id={review_request.diff_id}" | ||
| parts = [f"(Reviewing [[{diff_url}|Diff {review_request.diff_id}]])"] |
Member
There was a problem hiding this comment.
I suggest using Markdown instead of Remarkup, since it's more intuitive to read in logs. Phabricator supports both!
Suggested change
| parts = [f"(Reviewing [[{diff_url}|Diff {review_request.diff_id}]])"] | |
| parts = [f"(Reviewing [Diff {review_request.diff_id}]({diff_url}))"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a linkified diff reference to the top of the main review comment, so reviewers can tell which diff was reviewed at a glance.
Fixes #6029