[CODE HEALTH] clang-tidy `misc-use-internal-linkage` warnings part 2

[dbarker]

This issue covers resolving the misc-use-internal-linkage warnings:

misc-use-internal-linkage (95 warnings) - Click to expand

----

misc-use-internal-linkage (95 warnings)

File	Line	Message
opentelemetry-cpp/api/test/baggage/propagation/baggage_propagator_test.cc	23	class 'BaggageCarrierTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/context/propagation/composite_propagator_test.cc	41	class 'TextMapCarrierTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/context/propagation/composite_propagator_test.cc	61	class 'CompositePropagatorTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/context/propagation/environment_carrier_test.cc	59	class 'EnvironmentCarrierTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/logs/logger_test.cc	264	class 'TestLogger' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/logs/logger_test.cc	460	class 'TestProvider' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/logs/provider_test.cc	31	class 'TestProvider' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/nostd/shared_ptr_test.cc	16	class 'A' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/nostd/shared_ptr_test.cc	32	class 'B' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/nostd/shared_ptr_test.cc	38	class 'C' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/nostd/shared_ptr_test.cc	50	class 'D' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/nostd/unique_ptr_test.cc	13	class 'A' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/nostd/unique_ptr_test.cc	29	class 'B' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/nostd/variant_test.cc	11	class 'DestroyCounter' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/singleton/singleton_test.cc	166	class 'MyTracer' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/singleton/singleton_test.cc	301	class 'MyTracerProvider' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/trace/propagation/b3_propagation_test.cc	30	class 'TextMapCarrierTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/trace/propagation/detail/string_test.cc	49	class 'SplitStringTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/trace/propagation/http_text_format_test.cc	35	class 'TextMapCarrierTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/trace/propagation/jaeger_propagation_test.cc	33	class 'TextMapCarrierTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/api/test/trace/provider_test.cc	18	class 'TestProvider' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/elasticsearch/src/es_log_record_exporter.cc	47	class 'ResponseHandler' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/elasticsearch/src/es_log_record_exporter.cc	210	class 'AsyncResponseHandler' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/elasticsearch/src/es_log_recordable.cc	35	struct 'json_assign_visitor' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/memory/test/in_memory_metric_exporter_test.cc	27	class 'InMemoryMetricExporterTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/ostream/test/ostream_span_test.cc	46	class 'TestResource' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/src/otlp_file_client.cc	978	class 'OtlpFileSystemBackend' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/src/otlp_file_client.cc	1596	class 'OtlpFileOstreamBackend' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_file_client_test.cc	60	class 'ProtobufGlobalSymbolGuard' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_file_exporter_test.cc	62	class 'ProtobufGlobalSymbolGuard' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_file_exporter_test.cc	79	class 'OtlpFileExporterTestPeer' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_file_log_record_exporter_test.cc	48	class 'ProtobufGlobalSymbolGuard' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_file_log_record_exporter_test.cc	65	class 'OtlpFileLogRecordExporterTestPeer' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_file_metric_exporter_test.cc	46	class 'ProtobufGlobalSymbolGuard' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_grpc_exporter_test.cc	456	struct 'TestTraceService' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_grpc_exporter_test.cc	477	class 'OtlpGrpcExporterRetryIntegrationTests' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_http_exporter_test.cc	780	class 'OtlpHttpExporterRetryIntegrationTests' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_log_recordable_test.cc	257	struct 'OtlpLogRecordableIntAttributeTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_recordable_test.cc	552	struct 'EmptyArrayAttributeTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/otlp/test/otlp_recordable_test.cc	580	struct 'IntAttributeTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/prometheus/test/collector_test.cc	23	class 'MockMetricProducer' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/prometheus/test/collector_test.cc	47	class 'MockMetricReader' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/prometheus/test/exporter_utils_test.cc	289	class 'SanitizeTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/prometheus/test/exporter_utils_test.cc	324	class 'AttributeCollisionTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/zipkin/test/zipkin_exporter_test.cc	63	class 'MockHttpClient' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/zipkin/test/zipkin_exporter_test.cc	84	class 'IsValidMessageMatcher' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/exporters/zipkin/test/zipkin_recordable_test.cc	272	struct 'ZipkinIntAttributeTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/ext/test/http/url_parser_test.cc	15	struct 'ParsedUrl' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/ext/test/http/url_parser_test.cc	32	class 'UrlParserTests' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/ext/test/http/url_parser_test.cc	117	class 'UrlDecoderTests' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/functional/otlp/func_grpc_main.cc	42	enum 'TestMode' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/functional/otlp/func_http_main.cc	41	enum 'test_mode' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/common/global_log_handle_singleton_lifetime_test.cc	14	class 'GlobalLogHandlerChecker' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/common/global_log_handle_singleton_lifetime_test.cc	50	class 'CustomLogHandler' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/common/global_log_handle_test.cc	13	class 'CustomLogHandler' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/batch_log_record_processor_test.cc	39	class 'MockLogRecordable' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/batch_log_record_processor_test.cc	90	class 'MockLogExporter' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/batch_log_record_processor_test.cc	160	class 'BatchLogRecordProcessorTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/log_record_test.cc	89	class 'TestBodyLogger' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/log_record_test.cc	143	class 'TestBodyProvider' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/logger_config_test.cc	93	class 'DefaultLoggerConfiguratorTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/logger_provider_sdk_test.cc	213	class 'DummyLogRecordable' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/logger_provider_sdk_test.cc	243	class 'DummyProcessor' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/logs/logger_provider_set_test.cc	31	class 'TestProvider' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/async_metric_storage_test.cc	40	class 'WritableMetricStorageTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/async_metric_storage_test.cc	43	class 'WritableMetricStorageTestUpDownFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/async_metric_storage_test.cc	47	class 'WritableMetricStorageTestObservableGaugeFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/attributes_hashmap_test.cc	85	class 'MetricAttributeMapHashForCollision' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/cardinality_limit_test.cc	104	class 'WritableMetricStorageCardinalityLimitTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/circular_buffer_counter_test.cc	13	class 'AdaptingIntegerArrayTest' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/exemplar/aligned_histogram_bucket_exemplar_reservoir_test.cc	26	class 'AlignedHistogramBucketExemplarReservoirTestPeer' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/measurements_benchmark.cc	38	class 'MockMetricExporter' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/meter_config_test.cc	75	class 'DefaultMeterConfiguratorTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/metric_test_stress.cc	38	class 'MockMetricExporterForStress' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/multi_metric_storage_test.cc	17	class 'TestMetricStorage' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/periodic_exporting_metric_reader_test.cc	32	class 'MockPushMetricExporter' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/periodic_exporting_metric_reader_test.cc	64	class 'MockMetricProducer' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/sum_aggregation_test.cc	417	class 'UpDownCounterToSumFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/sync_metric_storage_counter_test.cc	37	class 'WritableMetricStorageTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/sync_metric_storage_gauge_test.cc	39	class 'WritableMetricStorageTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/sync_metric_storage_gauge_test.cc	42	class 'WritableMetricStorageDeltaMultiReaderTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/sync_metric_storage_histogram_test.cc	37	class 'WritableMetricStorageHistogramTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/metrics/sync_metric_storage_up_down_counter_test.cc	36	class 'WritableMetricStorageTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/resource/resource_test.cc	30	class 'TestResource' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/resource/resource_test.cc	39	class 'TestResourceDetector' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/batch_span_processor_test.cc	38	class 'MockSpanExporter' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/batch_span_processor_test.cc	108	class 'BatchSpanProcessorTestPeer' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/batch_span_processor_test.cc	221	struct 'MockLogHandler' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/simple_processor_test.cc	46	class 'RecordShutdownExporter' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/simple_processor_test.cc	110	class 'FailShutDownForceFlushExporter' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/tracer_config_test.cc	75	class 'DefaultTracerConfiguratorTestFixture' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/tracer_provider_set_test.cc	27	class 'TestProvider' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/tracer_test.cc	74	class 'MockSampler' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/tracer_test.cc	114	class 'MockDecisionSampler' can be moved into an anonymous namespace to enforce internal linkage
opentelemetry-cpp/sdk/test/trace/tracer_test.cc	155	class 'MockIdGenerator' can be moved into an anonymous namespace to enforce internal linkage

[github-actions]

This issue is available for anyone to work on. Make sure to reference this issue in your pull request.
✨ Thank you for your contribution! ✨

[dbarker]

See #2053

[mateenali66]

I'd like to work on this.

[thc1006]

Hi @mateenali66, I noticed you expressed interest in this on June 30. Since it has been open for about a week without a PR, I have started working through it in batches. I am opening the first batch now, covering the api/test and sdk/test files (roughly two thirds of the warnings). The exporters, ext, and functional test files are still open, so please feel free to take those if you would like to continue, or let me know and I am happy to coordinate or hand any part back. Thanks for tracking this.