Add support for nova's unpin-az microversion 104

Generated-By: Claude Opus 4.6
Depends-On: https://review.opendev.org/c/openstack/nova/+/990682
Change-Id: I5da2a6c945b2885e2fe427e3496615bf312cb8ae
Signed-off-by: Dan Smith <dansmith@redhat.com>

Author: kk7ds

openstackclient/compute/v2/server.py

@@ -4677,6 +4677,16 @@ def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
                 '(supported by --os-compute-api-version 2.90 or above)'
             ),
         )
+        parser.add_argument(
+            '--pinned-availability-zone',
+            metavar='<availability-zone>',
+            help=_(
+                'Pin the server to the given availability zone. '
+                'The server must currently be in the given zone. '
+                'To unpin, use "server unset --pinned-availability-zone" '
+                '(supported by --os-compute-api-version 2.104 or above)'
+            ),
+        )
         return parser
 
     @staticmethod
@@ -4723,6 +4733,14 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
                 )
                 raise exceptions.CommandError(msg)
 
+        if parsed_args.pinned_availability_zone:
+            if not sdk_utils.supports_microversion(compute_client, '2.104'):
+                msg = _(
+                    '--os-compute-api-version 2.104 or greater is required '
+                    'to support the --pinned-availability-zone option'
+                )
+                raise exceptions.CommandError(msg)
+
         update_kwargs = {}
 
         if parsed_args.name:
@@ -4734,6 +4752,11 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
         if parsed_args.hostname:
             update_kwargs['hostname'] = parsed_args.hostname
 
+        if parsed_args.pinned_availability_zone:
+            update_kwargs['pinned_availability_zone'] = (
+                parsed_args.pinned_availability_zone
+            )
+
         if update_kwargs:
             compute_client.update_server(server, **update_kwargs)
 
@@ -5330,6 +5353,15 @@ def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
                 '(supported by --os-compute-api-version 2.26 or above)'
             ),
         )
+        parser.add_argument(
+            '--pinned-availability-zone',
+            dest='pinned_availability_zone',
+            action='store_true',
+            help=_(
+                'Unpin the server from its availability zone '
+                '(supported by --os-compute-api-version 2.104 or above)'
+            ),
+        )
         return parser
 
     def take_action(self, parsed_args: argparse.Namespace) -> None:
@@ -5354,6 +5386,16 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
 
             compute_client.update_server(server, description="")
 
+        if parsed_args.pinned_availability_zone:
+            if not sdk_utils.supports_microversion(compute_client, '2.104'):
+                msg = _(
+                    '--os-compute-api-version 2.104 or greater is required '
+                    'to support the --pinned-availability-zone option'
+                )
+                raise exceptions.CommandError(msg)
+
+            compute_client.update_server(server, pinned_availability_zone=None)
+
         if parsed_args.tags or parsed_args.all_tags:
             if not sdk_utils.supports_microversion(compute_client, '2.26'):
                 msg = _(

openstackclient/tests/unit/compute/v2/test_server.py

@@ -8605,6 +8605,49 @@ def test_server_set_with_hostname_pre_v290(self):
             exceptions.CommandError, self.cmd.take_action, parsed_args
         )
 
+    def test_server_set_with_pinned_availability_zone(self):
+        self.set_compute_api_version('2.104')
+
+        arglist = [
+            '--pinned-availability-zone',
+            'az1',
+            self.server.id,
+        ]
+        verifylist = [
+            ('pinned_availability_zone', 'az1'),
+            ('server', self.server.id),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        result = self.cmd.take_action(parsed_args)
+
+        self.compute_client.update_server.assert_called_once_with(
+            self.server, pinned_availability_zone='az1'
+        )
+        self.compute_client.set_server_metadata.assert_not_called()
+        self.compute_client.reset_server_state.assert_not_called()
+        self.compute_client.change_server_password.assert_not_called()
+        self.compute_client.clear_server_password.assert_not_called()
+        self.compute_client.add_tag_to_server.assert_not_called()
+        self.assertIsNone(result)
+
+    def test_server_set_with_pinned_availability_zone_pre_v2104(self):
+        self.set_compute_api_version('2.103')
+
+        arglist = [
+            '--pinned-availability-zone',
+            'az1',
+            self.server.id,
+        ]
+        verifylist = [
+            ('pinned_availability_zone', 'az1'),
+            ('server', self.server.id),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        self.assertRaises(
+            exceptions.CommandError, self.cmd.take_action, parsed_args
+        )
+
 
 class TestServerShelve(TestServer):
     def setUp(self):
@@ -9408,6 +9451,46 @@ def test_server_unset_with_tag_pre_v226(self):
             '--os-compute-api-version 2.26 or greater is required', str(ex)
         )
 
+    def test_server_unset_with_pinned_availability_zone(self):
+        self.set_compute_api_version('2.104')
+
+        arglist = [
+            '--pinned-availability-zone',
+            self.server.id,
+        ]
+        verifylist = [
+            ('pinned_availability_zone', True),
+            ('server', self.server.id),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        result = self.cmd.take_action(parsed_args)
+
+        self.compute_client.update_server.assert_called_once_with(
+            self.server, pinned_availability_zone=None
+        )
+        self.assertIsNone(result)
+
+    def test_server_unset_with_pinned_availability_zone_pre_v2104(self):
+        self.set_compute_api_version('2.103')
+
+        arglist = [
+            '--pinned-availability-zone',
+            self.server.id,
+        ]
+        verifylist = [
+            ('pinned_availability_zone', True),
+            ('server', self.server.id),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        ex = self.assertRaises(
+            exceptions.CommandError, self.cmd.take_action, parsed_args
+        )
+        self.assertIn(
+            '--os-compute-api-version 2.104 or greater is required', str(ex)
+        )
+
 
 class TestServerUnshelve(TestServer):
     def setUp(self):