From 20d9945db2c5341c99f2cce15e6d93c9cd27ff19 Mon Sep 17 00:00:00 2001 From: ignaciosantise <25931366+ignaciosantise@users.noreply.github.com> Date: Mon, 29 Jun 2026 18:05:29 -0300 Subject: [PATCH 1/8] ci(maestro): bump WalletConnect/actions to a6436df for redesigned /collect IC form Provisionally pinned to the branch tip of WalletConnect/actions#106 (KYC /collect inline IC form redesign). Re-pin to the merged-master SHA before merging, and only after buyer-experience #914 is deployed. Co-Authored-By: Claude Opus 4.8 --- .../actions/walletkit-build-and-maestro/action.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/actions/walletkit-build-and-maestro/action.yml b/.github/actions/walletkit-build-and-maestro/action.yml index 7bb8e30d..b17e9fe0 100644 --- a/.github/actions/walletkit-build-and-maestro/action.yml +++ b/.github/actions/walletkit-build-and-maestro/action.yml @@ -427,14 +427,13 @@ runs: sudo udevadm trigger --name-match=kvm # --- Common: Maestro setup + run --- - # Pinned to WalletConnect/actions master tip (3fd66ca = squash-merge of #97). - # Includes #96's launchApp retry-on-attach-failure block in pay_open_and_paste_url.yaml - # plus #97's USDT-on-Polygon flow + permit2-reset action. + # Provisionally pinned to WalletConnect/actions#106 branch tip (KYC /collect IC + # redesign). Re-pin to the merged-master SHA before this PR leaves draft. - name: Copy shared Pay test flows - uses: WalletConnect/actions/maestro/pay-tests@3fd66ca1de3848a089d8e3c628e6f54bfcfd999f + uses: WalletConnect/actions/maestro/pay-tests@a6436dfbb6404e7c086b24054821eb8efcc41b22 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Install Maestro - uses: WalletConnect/actions/maestro/setup@3fd66ca1de3848a089d8e3c628e6f54bfcfd999f + uses: WalletConnect/actions/maestro/setup@a6436dfbb6404e7c086b24054821eb8efcc41b22 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Run Maestro tests (iOS) if: inputs.platform == 'ios' @@ -603,7 +602,7 @@ runs: # (actions/runner#1457), so non-fatal behavior is enforced via fail-on-error. - name: Reset USDT Permit2 allowance (Polygon) if: always() && contains(inputs.maestro-tags, 'pay') - uses: WalletConnect/actions/maestro/permit2-reset@8a83c203760286acef29408833dbd0d075932932 + uses: WalletConnect/actions/maestro/permit2-reset@a6436dfbb6404e7c086b24054821eb8efcc41b22 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge with: chain-id: eip155:137 rpc-url: ${{ inputs.polygon-rpc-url }} From 4ecb93fb62c85e005e5020d701ae8f30c5da41df Mon Sep 17 00:00:00 2001 From: ignaciosantise <25931366+ignaciosantise@users.noreply.github.com> Date: Fri, 3 Jul 2026 13:03:12 -0300 Subject: [PATCH 2/8] ci(maestro): re-pin WalletConnect/actions to bb4ed70 (#106 branch tip) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Still provisional — re-pin to the merged-master SHA before merge. Advances a6436df -> bb4ed70 so CI exercises the text-based consent ("0") and "Confirm" selectors; the earlier testIDs were not exposed in the /collect WebView. Co-Authored-By: Claude Opus 4.8 --- .github/actions/walletkit-build-and-maestro/action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/walletkit-build-and-maestro/action.yml b/.github/actions/walletkit-build-and-maestro/action.yml index b17e9fe0..4400d9d4 100644 --- a/.github/actions/walletkit-build-and-maestro/action.yml +++ b/.github/actions/walletkit-build-and-maestro/action.yml @@ -430,10 +430,10 @@ runs: # Provisionally pinned to WalletConnect/actions#106 branch tip (KYC /collect IC # redesign). Re-pin to the merged-master SHA before this PR leaves draft. - name: Copy shared Pay test flows - uses: WalletConnect/actions/maestro/pay-tests@a6436dfbb6404e7c086b24054821eb8efcc41b22 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/pay-tests@bb4ed7054daa7810f387bf307b42c5d4a1efb2da # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Install Maestro - uses: WalletConnect/actions/maestro/setup@a6436dfbb6404e7c086b24054821eb8efcc41b22 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/setup@bb4ed7054daa7810f387bf307b42c5d4a1efb2da # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Run Maestro tests (iOS) if: inputs.platform == 'ios' @@ -602,7 +602,7 @@ runs: # (actions/runner#1457), so non-fatal behavior is enforced via fail-on-error. - name: Reset USDT Permit2 allowance (Polygon) if: always() && contains(inputs.maestro-tags, 'pay') - uses: WalletConnect/actions/maestro/permit2-reset@a6436dfbb6404e7c086b24054821eb8efcc41b22 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/permit2-reset@bb4ed7054daa7810f387bf307b42c5d4a1efb2da # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge with: chain-id: eip155:137 rpc-url: ${{ inputs.polygon-rpc-url }} From a416d6c7ca961e9bd383fe43d36dec322c4ec2c0 Mon Sep 17 00:00:00 2001 From: ignaciosantise <25931366+ignaciosantise@users.noreply.github.com> Date: Fri, 3 Jul 2026 13:14:31 -0300 Subject: [PATCH 3/8] ci(maestro): re-pin WalletConnect/actions to bb0d5b1 (#106 w/ master merged) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #106 now has master (#107 skip-metrics) merged in, so this single SHA carries both the redesigned /collect flow fixes and the skip-metrics marker support. Still provisional — re-pin to the merged-master SHA once #106 lands. Co-Authored-By: Claude Opus 4.8 --- .github/actions/walletkit-build-and-maestro/action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/walletkit-build-and-maestro/action.yml b/.github/actions/walletkit-build-and-maestro/action.yml index e8f561ca..062e452a 100644 --- a/.github/actions/walletkit-build-and-maestro/action.yml +++ b/.github/actions/walletkit-build-and-maestro/action.yml @@ -517,10 +517,10 @@ runs: # Provisionally pinned to WalletConnect/actions#106 branch tip (KYC /collect IC # redesign). Re-pin to the merged-master SHA before this PR leaves draft. - name: Copy shared Pay test flows - uses: WalletConnect/actions/maestro/pay-tests@bb4ed7054daa7810f387bf307b42c5d4a1efb2da # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/pay-tests@bb0d5b1f7acf76a8681444f5ccb094730a1912b2 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Install Maestro - uses: WalletConnect/actions/maestro/setup@bb4ed7054daa7810f387bf307b42c5d4a1efb2da # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/setup@bb0d5b1f7acf76a8681444f5ccb094730a1912b2 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Run Maestro tests (iOS) if: inputs.platform == 'ios' @@ -821,7 +821,7 @@ runs: # steps — actions/runner#1457). - name: Reset USDT Permit2 allowance (Polygon) if: always() && contains(inputs.maestro-tags, 'pay') - uses: WalletConnect/actions/maestro/permit2-reset@bb4ed7054daa7810f387bf307b42c5d4a1efb2da # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/permit2-reset@bb0d5b1f7acf76a8681444f5ccb094730a1912b2 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge with: chain-id: eip155:137 rpc-url: ${{ inputs.polygon-rpc-url }} From 01dfc8b5098fa0d46d33c69e4259c0faa8feaa5d Mon Sep 17 00:00:00 2001 From: ignaciosantise <25931366+ignaciosantise@users.noreply.github.com> Date: Fri, 3 Jul 2026 15:20:45 -0300 Subject: [PATCH 4/8] ci(maestro): re-pin WalletConnect/actions to 27c02b0 (#106 tip) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #106 now taps the "I agree" consent label instead of the "0" value node, which did not toggle consent in CI. Still provisional — re-pin to the merged-master SHA once #106 lands. Co-Authored-By: Claude Opus 4.8 --- .github/actions/walletkit-build-and-maestro/action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/walletkit-build-and-maestro/action.yml b/.github/actions/walletkit-build-and-maestro/action.yml index 062e452a..1d526f46 100644 --- a/.github/actions/walletkit-build-and-maestro/action.yml +++ b/.github/actions/walletkit-build-and-maestro/action.yml @@ -517,10 +517,10 @@ runs: # Provisionally pinned to WalletConnect/actions#106 branch tip (KYC /collect IC # redesign). Re-pin to the merged-master SHA before this PR leaves draft. - name: Copy shared Pay test flows - uses: WalletConnect/actions/maestro/pay-tests@bb0d5b1f7acf76a8681444f5ccb094730a1912b2 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/pay-tests@27c02b08f4659e67c95679097fa0e34dffd413ec # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Install Maestro - uses: WalletConnect/actions/maestro/setup@bb0d5b1f7acf76a8681444f5ccb094730a1912b2 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/setup@27c02b08f4659e67c95679097fa0e34dffd413ec # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Run Maestro tests (iOS) if: inputs.platform == 'ios' @@ -821,7 +821,7 @@ runs: # steps — actions/runner#1457). - name: Reset USDT Permit2 allowance (Polygon) if: always() && contains(inputs.maestro-tags, 'pay') - uses: WalletConnect/actions/maestro/permit2-reset@bb0d5b1f7acf76a8681444f5ccb094730a1912b2 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/permit2-reset@27c02b08f4659e67c95679097fa0e34dffd413ec # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge with: chain-id: eip155:137 rpc-url: ${{ inputs.polygon-rpc-url }} From 1e1c3c24afaa745319f34ec1978d58b09c9bb6b6 Mon Sep 17 00:00:00 2001 From: ignaciosantise <25931366+ignaciosantise@users.noreply.github.com> Date: Fri, 3 Jul 2026 15:57:12 -0300 Subject: [PATCH 5/8] ci(maestro): re-pin WalletConnect/actions to e823a98 (#106 tip) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #106 now scrolls until the Confirm button is visible (off-screen on small devices). Still provisional — re-pin to merged-master SHA once #106 lands. Co-Authored-By: Claude Opus 4.8 --- .github/actions/walletkit-build-and-maestro/action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/walletkit-build-and-maestro/action.yml b/.github/actions/walletkit-build-and-maestro/action.yml index 1d526f46..459c162a 100644 --- a/.github/actions/walletkit-build-and-maestro/action.yml +++ b/.github/actions/walletkit-build-and-maestro/action.yml @@ -517,10 +517,10 @@ runs: # Provisionally pinned to WalletConnect/actions#106 branch tip (KYC /collect IC # redesign). Re-pin to the merged-master SHA before this PR leaves draft. - name: Copy shared Pay test flows - uses: WalletConnect/actions/maestro/pay-tests@27c02b08f4659e67c95679097fa0e34dffd413ec # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/pay-tests@e823a982c878b762d223c628b96f408b69ffcff1 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Install Maestro - uses: WalletConnect/actions/maestro/setup@27c02b08f4659e67c95679097fa0e34dffd413ec # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/setup@e823a982c878b762d223c628b96f408b69ffcff1 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Run Maestro tests (iOS) if: inputs.platform == 'ios' @@ -821,7 +821,7 @@ runs: # steps — actions/runner#1457). - name: Reset USDT Permit2 allowance (Polygon) if: always() && contains(inputs.maestro-tags, 'pay') - uses: WalletConnect/actions/maestro/permit2-reset@27c02b08f4659e67c95679097fa0e34dffd413ec # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/permit2-reset@e823a982c878b762d223c628b96f408b69ffcff1 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge with: chain-id: eip155:137 rpc-url: ${{ inputs.polygon-rpc-url }} From 5c9e3d5cdf6df2e65a8645e8d791a47b1de8e7a8 Mon Sep 17 00:00:00 2001 From: ignaciosantise <25931366+ignaciosantise@users.noreply.github.com> Date: Fri, 3 Jul 2026 16:49:39 -0300 Subject: [PATCH 6/8] ci(maestro): re-pin WalletConnect/actions to bf68e7d (#106 tip) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #106 now uses the verified KYC sequence (scroll+tap 'I agree', scroll+tap 'Confirm'). Still provisional — re-pin to merged-master SHA once #106 lands. Co-Authored-By: Claude Opus 4.8 --- .github/actions/walletkit-build-and-maestro/action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/walletkit-build-and-maestro/action.yml b/.github/actions/walletkit-build-and-maestro/action.yml index 459c162a..7fe6df22 100644 --- a/.github/actions/walletkit-build-and-maestro/action.yml +++ b/.github/actions/walletkit-build-and-maestro/action.yml @@ -517,10 +517,10 @@ runs: # Provisionally pinned to WalletConnect/actions#106 branch tip (KYC /collect IC # redesign). Re-pin to the merged-master SHA before this PR leaves draft. - name: Copy shared Pay test flows - uses: WalletConnect/actions/maestro/pay-tests@e823a982c878b762d223c628b96f408b69ffcff1 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/pay-tests@bf68e7debde224f0a53427515414265d0ba42a0f # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Install Maestro - uses: WalletConnect/actions/maestro/setup@e823a982c878b762d223c628b96f408b69ffcff1 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/setup@bf68e7debde224f0a53427515414265d0ba42a0f # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge - name: Run Maestro tests (iOS) if: inputs.platform == 'ios' @@ -821,7 +821,7 @@ runs: # steps — actions/runner#1457). - name: Reset USDT Permit2 allowance (Polygon) if: always() && contains(inputs.maestro-tags, 'pay') - uses: WalletConnect/actions/maestro/permit2-reset@e823a982c878b762d223c628b96f408b69ffcff1 # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/permit2-reset@bf68e7debde224f0a53427515414265d0ba42a0f # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge with: chain-id: eip155:137 rpc-url: ${{ inputs.polygon-rpc-url }} From 02523b94de6c0f7722758af1f0931e8593e4ed81 Mon Sep 17 00:00:00 2001 From: Ignacio Santise <25931366+ignaciosantise@users.noreply.github.com> Date: Fri, 3 Jul 2026 17:24:33 -0300 Subject: [PATCH 7/8] fix(rn_cli_wallet): allow vertical scroll in CollectData KYC webview The redesigned /collect IC form is taller than the viewport, but the webview clipped content two ways: scrollEnabled/nestedScrollEnabled were false, and the injected viewport CSS forced `overflow: hidden` on html/body. Together they made the consent checkbox + Confirm button unreachable (and Maestro scrolls no-op'd) on Android. Enable scrollEnabled/nestedScrollEnabled and switch the injected CSS to `overflow-x: hidden; overflow-y: auto` (keeping overscroll-behavior:none to avoid rubber-banding). Co-Authored-By: Claude Opus 4.8 --- .../src/modals/PaymentOptionsModal/CollectDataWebView.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/wallets/rn_cli_wallet/src/modals/PaymentOptionsModal/CollectDataWebView.tsx b/wallets/rn_cli_wallet/src/modals/PaymentOptionsModal/CollectDataWebView.tsx index ab56949a..6bf13bee 100644 --- a/wallets/rn_cli_wallet/src/modals/PaymentOptionsModal/CollectDataWebView.tsx +++ b/wallets/rn_cli_wallet/src/modals/PaymentOptionsModal/CollectDataWebView.tsx @@ -37,7 +37,7 @@ const PRELOAD_VIEWPORT_JS = ` style = document.createElement('style'); style.id = 'rn-webview-fit-style'; style.textContent = - 'html, body { margin: 0 !important; padding: 0 !important; width: 100% !important; max-width: 100% !important; overflow: hidden !important; overscroll-behavior: none !important; }'; + 'html, body { margin: 0 !important; padding: 0 !important; width: 100% !important; max-width: 100% !important; overflow-x: hidden !important; overflow-y: auto !important; overscroll-behavior: none !important; }'; head.appendChild(style); } } @@ -259,8 +259,8 @@ export function CollectDataWebView({ javaScriptEnabled domStorageEnabled startInLoadingState - scrollEnabled={false} - nestedScrollEnabled={false} + scrollEnabled={true} + nestedScrollEnabled={true} bounces={false} overScrollMode="never" setBuiltInZoomControls={false} From 68efa3e4fe4a7f8fc1482fc12c0417e58bfbf9b3 Mon Sep 17 00:00:00 2001 From: ignaciosantise <25931366+ignaciosantise@users.noreply.github.com> Date: Fri, 3 Jul 2026 17:50:51 -0300 Subject: [PATCH 8/8] ci(maestro): pin WalletConnect/actions to ddc7c0f (merged #106) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit WalletConnect/actions#106 merged to master (ddc7c0f) — the redesigned /collect inline IC flow fixes. Pin to the merged-master SHA and drop the provisional note. Co-Authored-By: Claude Opus 4.8 --- .github/actions/walletkit-build-and-maestro/action.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/actions/walletkit-build-and-maestro/action.yml b/.github/actions/walletkit-build-and-maestro/action.yml index 7fe6df22..5cd20e25 100644 --- a/.github/actions/walletkit-build-and-maestro/action.yml +++ b/.github/actions/walletkit-build-and-maestro/action.yml @@ -514,13 +514,13 @@ runs: curl -fsS -o /dev/null http://localhost:8081 || { echo "Static web server failed:"; cat "${RUNNER_TEMP}/web-serve.log"; exit 1; } # --- Common: Maestro setup + run --- - # Provisionally pinned to WalletConnect/actions#106 branch tip (KYC /collect IC - # redesign). Re-pin to the merged-master SHA before this PR leaves draft. + # Pinned to WalletConnect/actions master (ddc7c0f = merge of #106, the + # redesigned /collect inline IC flow). - name: Copy shared Pay test flows - uses: WalletConnect/actions/maestro/pay-tests@bf68e7debde224f0a53427515414265d0ba42a0f # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/pay-tests@ddc7c0f9acd8b1576e9a78f0ef67f4b8fbb36db2 - name: Install Maestro - uses: WalletConnect/actions/maestro/setup@bf68e7debde224f0a53427515414265d0ba42a0f # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/setup@ddc7c0f9acd8b1576e9a78f0ef67f4b8fbb36db2 - name: Run Maestro tests (iOS) if: inputs.platform == 'ios' @@ -821,7 +821,7 @@ runs: # steps — actions/runner#1457). - name: Reset USDT Permit2 allowance (Polygon) if: always() && contains(inputs.maestro-tags, 'pay') - uses: WalletConnect/actions/maestro/permit2-reset@bf68e7debde224f0a53427515414265d0ba42a0f # provisional — re-pin to merged-master SHA of WalletConnect/actions#106 before merge + uses: WalletConnect/actions/maestro/permit2-reset@ddc7c0f9acd8b1576e9a78f0ef67f4b8fbb36db2 with: chain-id: eip155:137 rpc-url: ${{ inputs.polygon-rpc-url }}