ci: add a sandbox workflow to test Artifactory resolution on any branch#1387
ci: add a sandbox workflow to test Artifactory resolution on any branch#1387abueide wants to merge 2 commits into
Conversation
Testing whether a dependency change resolves cleanly through curated Artifactory (catching curation-policy 403s like the ones fixed in #1385/#1386) has meant triggering release.yml itself via workflow_dispatch on a scratch branch - which works, but also arms the publish job (harmless since it needs the production environment's approval and never gets it, but not clean, and it's easy to forget that job is sitting there). This is a standalone workflow instead: manual-only, no should-release gate, no publish job, nothing else it can accidentally trigger. Push any candidate resolutions/yarn.lock change to a branch and run: gh workflow run test-artifactory-install.yml --ref <branch> Deliberately doesn't cache yarn's dependency cache the way release.yml's test job does - a warm cache can serve packages from GitHub's own cache without ever making a real request to Artifactory, masking exactly the kind of curation failure this exists to catch.
|
✅ TVS Validation PassedShow detailsAll validation checks have successfully completed. |
release.yml's test job (Node 20) and publish job (Node 24) can resolve different dependency trees - confirmed twice now, is-email and axios each showed up curation-blocked under one Node version's install but not the other's. Matrix this across both versions so the sandbox actually covers what a real release run would hit.
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit b9183ce to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #1387 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 46 46
Lines 1375 1375
Branches 322 322
=======================================
Hits 1234 1234
Misses 141 141
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Summary
Testing whether a dependency change resolves cleanly through curated Artifactory (catching curation-policy 403s like the ones fixed in #1385/#1386) has meant triggering
release.ymlitself viaworkflow_dispatchon a scratch branch. That works, but it also arms thepublishjob - harmless since it needs theproductionenvironment's manual approval and never gets it, but not clean, and easy to lose track of.Change
A standalone workflow instead: manual-only, no
should-releasegate, nopublishjob, nothing else it can accidentally trigger. Push any candidateresolutions/yarn.lockchange to a branch and run:Deliberately doesn't cache yarn's dependency cache the way
release.yml'stestjob does - a warm cache can serve packages from GitHub's own cache without ever making a real request to Artifactory, masking exactly the kind of curation failure this exists to catch.