From 49c17afdeee8066d87fd6190eee7f7a7d5acf0f1 Mon Sep 17 00:00:00 2001 From: Laith Al-Saadoon Date: Sun, 28 Jun 2026 12:37:15 +0000 Subject: [PATCH] ci: align verify-global-install budget to script default (60s -> 120s) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The macos-x64-node24-nvm leg has been flaking on `gate 4: install took 61s (> 60s budget)` — a 1-second margin miss on a clean install, not a real regression. scripts/verify-global-install.sh documents a 120s default and its own header explains the tight 60s "tripped on slow cells despite a clean install", but the workflow hardcoded MAX_INSTALL_SECS=60, contradicting that. The gate exists to catch an install that HANGS or refetches native prebuilts (ladybug + duckdb + onnxruntime), which on a loaded shared runner legitimately varies 30-90s — it is not a perf benchmark. Align the workflow to the script's 120s default. Fixes the recurring macOS-runner flake class tracked in #163. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/verify-global-install.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify-global-install.yml b/.github/workflows/verify-global-install.yml index c3bd490..4f37584 100644 --- a/.github/workflows/verify-global-install.yml +++ b/.github/workflows/verify-global-install.yml @@ -207,7 +207,14 @@ jobs: INSTALLER: ${{ matrix.installer }} TARBALL_DIR: ${{ runner.temp }}/opencodehub-tarballs FIXTURE_DIR: tests/fixtures/multi-lang - MAX_INSTALL_SECS: "60" + # Use the script's documented default budget. A cold-cache global + # install of the native prebuilts (ladybug + duckdb + onnxruntime) + # on a loaded shared runner legitimately varies 30-90s, so the old + # hardcoded 60s tripped on slow macOS cells despite a clean install + # (see scripts/verify-global-install.sh header + issue #163). The + # gate guards against an install that HANGS or refetches, not a perf + # benchmark, so 120s is the right ceiling. + MAX_INSTALL_SECS: "120" run: bash scripts/verify-global-install.sh local # ------------------------------------------------------------------