chore(ntx-builder): add note cycles check#2322
Open
SantiagoPittella wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1962.
Summary
The ntx-builder was permanently dropping network notes that are individually consumable but that don't fit within a single transaction's cycle budget. Because of how we were checking consumability, the checker sorts standard notes first, a large non-standard note (like an
AggLayernote) is consistently the one evicted. The builder then treats every failed note identically, bumping itsattempt_count, so aftermax_note_attemptsthe evicted note is dropped fromavailable_notesentirely, even though it would execute fine on its own.How:
In execute_transactions' success branch, failed notes are partitioned (
partition_failed_notes) onnum_cycles().is_some():Some: are individually consumable, evicted only for space. These are logged but not penalized.None: real consumability failures, penalized as before.Changelog