docs: correct P2ID note count and loop range in mint tutorial - #212
Open
memosr wants to merge 1 commit into
Open
docs: correct P2ID note count and loop range in mint tutorial#212memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paragraph introducing the multi-note output snippet describes five notes
over
0..=4, but the code creates four notes over1..=4.Three sources in the repo already agree on four:
rust-client/src/bin/create_mint_consume_send.rsprintsSubmitted a transaction with 4 P2ID notes1..=4handled in a single transaction, and the fifth transfer is a standard P2ID
transfer"
So the paragraph contradicted both the code below it and the prose six lines
above it. This aligns the wording with all three.
Text-only change, no code touched.
cargo test --docindocs/passes(17 passed, 0 failed). Ran
prettier --writeper CONTRIBUTING.md; the linewas already conformant.