docs: align unauthenticated note tutorial with 5-account source - #214
Open
memosr wants to merge 1 commit into
Open
docs: align unauthenticated note tutorial with 5-account source#214memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The account count in this tutorial disagreed with the real program in three
different ways:
number_of_accounts = 2rust-client/src/bin/unauthenticated_note_transfer.rssets it to5The source is canonical, and the tutorial's own transfer chain confirms it:
it runs
account_0toaccount_4, which is 5 accounts and 4 transfers.Changes:
5, matching the sourceaccount_4instead ofaccount_9blocks: [...]line: noprintln!in the current sourceemits it, so it is leftover output from an older version of the program
<duration>placeholders, matching the<account_N_id>style alreadyused in this block. Trimming 9 iterations to 4 would have made the old
totals wrong, and inventing replacement timings seemed worse than not
claiming a number
Left untouched deliberately: the MidenScan tx hashes and the
Latest blockheight. Those are ordinary per-run values and unrelated to the account count.
Docs-only change.
cargo test --docindocs/passes (17 passed, 0 failed).Ran
prettier --writeper CONTRIBUTING.md; the file was already conformant.