docs: propagate unwrap-to-? migration into tutorial snippets - #215
Open
memosr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-client/src/bin/uses the?operator onbuild_consume_notes, butthree tutorial snippets still call
.unwrap(). The migration reached thelarge
no_runlistings, which CI compiles, but not the smallerrust ignoresnippets, which are never compiled and so drifted silently.Three call sites, each now matching its source exactly:
mint_consume_create_tutorial.mdvscreate_mint_consume_send.rscustom_note_how_to.mdvshash_preimage_note.rsunauthenticated_note_how_to.mdvsunauthenticated_note_transfer.rsThe first one also resolves a contradiction inside its own file, which
already used
?in the final full listing further down.Line wrapping differs between the three because the sources differ:
consume_requestfits on one line,transaction_requestdoes not. Eachsnippet reproduces its own source rather than normalizing them.
Scope is limited to these three
build_consume_notescall sites. Norepo-wide
.unwrap()sweep was done, and other.unwrap()calls thatmatch their sources are untouched.
Docs-only change.
cargo test --docindocs/passes (17 passed, 0 failed).Ran
prettier --writeper CONTRIBUTING.md.