docs: pass project manifest to miden build - #223
Open
huklaa wants to merge 2 commits into
Open
Conversation
|
Once 0xMiden/midenup#234 lands on midenup, this will no longer be necessary. Users should use |
Author
|
Thanks, that makes sense. I’ll leave #223 open while 0xMiden/midenup#234 is still pending, and close this PR once that lands if the docs change is fully redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #210.
Updates the Miden Bank quick-start README and Part 0 setup guide to pass
miden-project.tomlexplicitly tomiden build, matching the maintainer guidance in #210 for toolchains wheremiden buildinvokesmidencdirectly.This keeps the existing
midenworkflow while avoiding theexpected input filefailure.