refactor: share wait_for_tx helper across Rust tutorials - #236
Open
huklaa wants to merge 4 commits into
Open
Conversation
huklaa
marked this pull request as ready for review
August 11, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
rust_client::wait_for_txhelper for Rust tutorial binaries.hash_preimage_note.rsoff its local duplicated transaction polling helper.network_notes_counter_contract.rsto the same shared helper while preserving its separate network-note polling delay.unauthenticated_note_transfer.rsto the shared helper as well, removing another identical polling implementation and its now-unused imports.Why
This advances #194 by moving repeated utility code into shared tutorial infrastructure so examples can focus on the protocol/client concept being demonstrated.
Scope
This PR stays focused on the duplicated
wait_for_txpath and three existing runnable consumers, establishing the shared helper without mixing in broader setup refactors.Closes part of #194.