fix: avoid Miden Bank deposit FPI name collision - #238
Open
huklaa wants to merge 5 commits into
Open
Conversation
huklaa
marked this pull request as ready for review
August 11, 2026 17:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining method-name collision reported in #237.
The bank contract already uses
get_depositor_balance, so theget_balancecollision has been addressed on currentmain. This change handles the remainingdepositcollision by renaming the exported bank component method tobank_deposit, updating the deposit-note FPI call, and aligning the Part 4 and Part 5 tutorial snippets, binding examples, WIT example, and flow diagrams with the collision-safe API.Scope is intentionally focused: runnable contract code plus the directly corresponding tutorial pages. Transaction behavior is unchanged apart from the exported method name.
Validation: compared against current upstream
mainand checked the updated Miden Bank docs for staleaccount.deposit(...)/fn depositbinding examples in the affected Part 4–5 flow. Full Miden build was not run in this automation environment because the local GitHub CLI/toolchain is unavailable.