Skip to content

fix: avoid Miden Bank deposit FPI name collision - #238

Open
huklaa wants to merge 5 commits into
0xMiden:mainfrom
huklaa:agent/fix-miden-bank-name-collisions-237
Open

fix: avoid Miden Bank deposit FPI name collision#238
huklaa wants to merge 5 commits into
0xMiden:mainfrom
huklaa:agent/fix-miden-bank-name-collisions-237

Conversation

@huklaa

@huklaa huklaa commented Aug 11, 2026

Copy link
Copy Markdown

Fixes the remaining method-name collision reported in #237.

The bank contract already uses get_depositor_balance, so the get_balance collision has been addressed on current main. This change handles the remaining deposit collision by renaming the exported bank component method to bank_deposit, updating the deposit-note FPI call, and aligning the Part 4 and Part 5 tutorial snippets, binding examples, WIT example, and flow diagrams with the collision-safe API.

Scope is intentionally focused: runnable contract code plus the directly corresponding tutorial pages. Transaction behavior is unchanged apart from the exported method name.

Validation: compared against current upstream main and checked the updated Miden Bank docs for stale account.deposit(...) / fn deposit binding examples in the affected Part 4–5 flow. Full Miden build was not run in this automation environment because the local GitHub CLI/toolchain is unavailable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant