Fix connect chain id normalization#602
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfc20332c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,21 @@ | |||
| import { describe, expect, it } from 'vitest' | |||
There was a problem hiding this comment.
In packages/connect, this new test is included by the package tsconfig's ./src/**/*.ts pattern, so pnpm --filter @0xsequence/connect typecheck/build:esm will try to resolve this import. I checked packages/connect/package.json and the lockfile importer for packages/connect, and vitest is not declared there (nor at the workspace root), so a fresh pnpm install cannot resolve vitest from this package and the connect build/typecheck will fail with TS2307 before publishing.
Useful? React with 👍 / 👎.
1 participant
Fixes connect chain id normalization so malformed values are rejected instead of being partially parsed or converted to unsafe numbers. Adds focused coverage for valid and invalid chain ids.