Skip to content

chore: block using mpmath==1.5.0a0 in pre test, as sympy is incompatybile with it#1421

Merged
Czaki merged 2 commits into
developfrom
fix_pre_pyinstalle
Jul 1, 2026
Merged

chore: block using mpmath==1.5.0a0 in pre test, as sympy is incompatybile with it#1421
Czaki merged 2 commits into
developfrom
fix_pre_pyinstalle

Conversation

@Czaki

@Czaki Czaki commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

closes #1398

Summary by Sourcery

Build:

  • Include mpmath.libmp in the PyInstaller hidden imports list to restore successful launcher builds.

@Czaki Czaki added this to the 0.17.1 milestone Jul 1, 2026
@sourcery-ai

sourcery-ai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates the PyInstaller spec to ensure upcoming versions of mpmath are correctly bundled by explicitly adding the required mpmath submodule to hidden imports.

File-Level Changes

Change Details Files
Ensure PyInstaller bundles the necessary mpmath components by extending the hidden imports list.
  • Add the mpmath.libmp submodule to the hiddenimports tuple used by the launcher PyInstaller spec
launcher.spec

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The launcher.spec file is modified to add mpmath.libmp as an additional hidden import in the PyInstaller hiddenimports tuple. No other configuration or logic is altered.

Changes

PyInstaller Configuration Update

Layer / File(s) Summary
Add hidden import
launcher.spec
Adds mpmath.libmp to the hiddenimports tuple so PyInstaller bundles it as a hidden dependency.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions blocking mpmath 1.5.0a0 in tests, but the change only adds a PyInstaller hidden import. Retitle it to match the actual build fix, e.g. "fix launcher.spec hidden import for mpmath.libmp".
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_pre_pyinstalle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Czaki Czaki changed the title Fix pyinstaller build for upcoming mpmath fix: Fix pyinstaller build for upcoming mpmath Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.56%. Comparing base (d69a26c) to head (c9e24a4).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1421      +/-   ##
===========================================
- Coverage    92.58%   92.56%   -0.02%     
===========================================
  Files          211      211              
  Lines        33224    33224              
===========================================
- Hits         30759    30754       -5     
- Misses        2465     2470       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Czaki Czaki added the skip check PR title skip spellcheking PR title label Jul 1, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@Czaki Czaki changed the title fix: Fix pyinstaller build for upcoming mpmath chore: block using mpmath==1.5.0a0 in pre test, as sympy is incompatybile with it Jul 1, 2026
@Czaki Czaki merged commit 0c7770d into develop Jul 1, 2026
57 checks passed
@Czaki Czaki deleted the fix_pre_pyinstalle branch July 1, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip check PR title skip spellcheking PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-bot] pyinstaller bundle --pre is failing

1 participant