Skip to content

chore: Block mpmath==1.5.0a0 for pre-tests#1423

Open
Czaki wants to merge 2 commits into
developfrom
fix_pyinstaller_v2
Open

chore: Block mpmath==1.5.0a0 for pre-tests#1423
Czaki wants to merge 2 commits into
developfrom
fix_pyinstaller_v2

Conversation

@Czaki

@Czaki Czaki commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

closes #1422

@sourcery-ai

sourcery-ai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds mpmath==1.5.0a0 to the pre-test and global version denylists so that this specific alpha version is blocked during pre-test runs and in general dependency resolution.

File-Level Changes

Change Details Files
Block the problematic mpmath==1.5.0a0 release in the pre-test problematic versions list.
  • Append or insert mpmath==1.5.0a0 into the list of pre-test problematic package versions so it will be excluded during pre-test runs.
  • Ensure formatting/order remains consistent with existing entries in the file.
requirements/pre_test_problematic_version.txt
Add mpmath==1.5.0a0 to the global version denylist used across the project.
  • Update the version denylist to include mpmath==1.5.0a0 so dependency resolution will avoid this version.
  • Preserve existing style and any ordering/grouping conventions in the denylist.
requirements/version_denylist.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1bfcc4e7-2771-436a-ad0b-653f90f5f9db

📥 Commits

Reviewing files that changed from the base of the PR and between 0c7770d and a291b98.

📒 Files selected for processing (2)
  • requirements/pre_test_problematic_version.txt
  • requirements/version_denylist.txt
💤 Files with no reviewable changes (1)
  • requirements/version_denylist.txt
👮 Files not reviewed due to content moderation or server errors (1)
  • requirements/pre_test_problematic_version.txt

📝 Walkthrough

[!WARNING]

Walkthrough skipped

File diffs could not be summarized.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_pyinstaller_v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Czaki Czaki added this to the 0.17.1 milestone Jul 2, 2026
@Czaki Czaki changed the title Block mpmath==1.5.0a0 for pre-tests chore: Block mpmath==1.5.0a0 for pre-tests Jul 2, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-bot] pyinstaller bundle --pre is failing

1 participant