Add option to include timestamps without values when fetching data via get_samples_aggregate()#147
Merged
Conversation
wojciech-bochniarz-4ss
requested review from
branislav-jenco-4ss and
ivan-nikalaichanka-4ss
February 25, 2026 11:47
wojciech-bochniarz-4ss
added
documentation
Contributor
Author
|
I see there is some broken test for different function. I will take a look at it |
ivan-nikalaichanka-4ss
previously approved these changes
Feb 25, 2026
ivan-nikalaichanka-4ss
left a comment
ivan-nikalaichanka-4ss
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
branislav-jenco-4ss
approved these changes
Mar 2, 2026
wojciech-bochniarz-4ss
deleted the
ESS-3967-add-option-in-drio-package-to-include-timestamps-without-values-when-fetching-data-from-adx
branch
March 2, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to task ESS-3967
Description
include_empty_aggregationswhile callingget_samples_aggregate()function. When set to true, result will include all aggregated timestamps, even when there is no data, values for those cases will be filled withNaN.