Skip to content

update rope_max_timescale to 1M for qwen3-30b-a3b-base to match HF#4039

Open
JamesDeng42 wants to merge 1 commit into
mainfrom
yujiedeng/repo-fix
Open

update rope_max_timescale to 1M for qwen3-30b-a3b-base to match HF#4039
JamesDeng42 wants to merge 1 commit into
mainfrom
yujiedeng/repo-fix

Conversation

@JamesDeng42
Copy link
Copy Markdown
Collaborator

Description

This PR updates the rope_max_timescale for the qwen3-30b-a3b-base model configuration from 10,000,000 to 1,000,000.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

🤖 Hi @gagika, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## 📋 Review Summary

This Pull Request correctly updates the rope_max_timescale (and its Hugging Face counterpart rope_theta) for the qwen3-30b-a3b-base model to align with the Hugging Face configuration. The change ensures consistency between the MaxText model configuration and the checkpoint conversion utilities.

🔍 General Feedback

  • The changes are focused and follow the established patterns in the codebase for model configuration and HF mapping.
  • I noticed that while the model has been added to hf_model_configs.py and param_mapping.py, it is currently missing from src/maxtext/checkpoint_conversion/utils/hf_shape.py. This omission will likely cause the to_huggingface conversion script to fail for this specific model variant. I have added an inline comment suggesting this addition.
  • Overall, the PR is high quality and addresses the requirement of matching HF configurations.

Comment thread src/maxtext/checkpoint_conversion/utils/hf_model_configs.py
@JamesDeng42 JamesDeng42 force-pushed the yujiedeng/repo-fix branch from 6ba34f4 to 659d5b1 Compare June 2, 2026 17:58
vocab_size=151936,
)

qwen3_30b_a3b_base_config = transformers.Qwen3MoeConfig(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you have qwen3_30b_a3b_thinking_2507_config inherit from qwen3_30b_a3b_base_config and just override rope_theta=1000000?

also @parambole could you review qwen3-30b base model config change to match hf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants