BUG: apply gimbaled thrust components to translational dynamics - #27
Open
ting-hong-shieh wants to merge 1 commit into
Conversation
Draft
8 tasks
ting-hong-shieh
marked this pull request as ready for review
August 15, 2026 01:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e1,e2, ande3components.r × F, including nozzle position and thrust eccentricity.Problem
At the head commit of RocketPy-Team/RocketPy#965, both 6-DoF equation paths reduce the axial thrust component and add pitch/yaw moments when TVC is active. The translational equations still omit the corresponding lateral thrust components: the regular path adds no thrust to its
e1ore2force terms, and the generalized path uses[0, 0, thrust3].As a result, a gimbal command changes the rotational dynamics without applying the commanded lateral force to the rocket's translation.
Implementation
Flight._calculate_thrust_vectornow produces one body-frame thrust vector using the signs implied by the existing moment equations:-e2+e1Both equation paths consume this vector. The moment contribution is calculated from the nozzle position and force with
r × F, which also retains the existing thrust-eccentricity behavior.This PR is limited to the physics correction on the branch behind RocketPy-Team#965. It does not rebase the actuator work onto
developor the Flight event/controller changes in RocketPy-Team/RocketPy#968.Validation
The new cases cover zero gimbal, positive and negative single-axis commands, two-axis magnitude preservation, and the nozzle moment from
r × F.References