Skip to content

Adding the RN Generator extra configuration#161

Open
tmikula-dev wants to merge 2 commits into
masterfrom
fix/adding-generator-rn-config
Open

Adding the RN Generator extra configuration#161
tmikula-dev wants to merge 2 commits into
masterfrom
fix/adding-generator-rn-config

Conversation

@tmikula-dev
Copy link
Copy Markdown
Collaborator

@tmikula-dev tmikula-dev commented May 26, 2026

Overview

This pull request introduces improvements to the GitHub Actions workflows, focusing on better workflow concurrency control and permissions management for release-related automation. The changes help prevent overlapping runs and ensure the workflows have the correct permissions to operate.

Summary by CodeRabbit

  • Chores
    • Improved release workflow stability by adding concurrency controls to prevent overlapping runs.
    • Set explicit permissions for draft release workflow to ensure reliable draft/tag creation.
    • Adjusted tag creation logic to produce consistent, reference-based tags for more predictable releases.

Review Change Stack

@tmikula-dev tmikula-dev self-assigned this May 26, 2026
@tmikula-dev tmikula-dev added bug Something isn't working no RN No release notes required labels May 26, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a34556df-b7d5-4f3f-b6ce-cd923903f129

📥 Commits

Reviewing files that changed from the base of the PR and between d2c40fe and 241f1a0.

📒 Files selected for processing (1)
  • .github/workflows/release_draft.yml

Walkthrough

Two GitHub Actions workflows updated: PR release-notes checks gain concurrency control to cancel overlapping runs per ref; the release draft workflow now declares explicit permissions and creates a tag reference directly at the commit SHA instead of constructing a tag object with tagger metadata.

Changes

Release Workflow Improvements

Layer / File(s) Summary
Concurrency control for PR release notes checks
.github/workflows/check_pr_release_notes.yml
Workflow-level concurrency groups runs by github.ref and cancels in-progress checks when a new run for the same ref is started.
Release draft permissions and tag creation
.github/workflows/release_draft.yml
Adds top-level permissions (contents: write, issues: read, pull-requests: read) and changes GitHub Script to create the tag ref via github.rest.git.createRef using context.sha (removing the prior tag object/tagger metadata flow).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • AbsaOSS/EventGate#158: Modifies the same release workflow tag/ref creation logic (createTag vs createRef).

Suggested labels

enhancement

Suggested reviewers

  • lsulak
  • petr-pokorny-absa
  • oto-macenauer-absa

Poem

🐰 I hopped through YAML, swift and spry,

Stitched a lock to keep checks from vying,
Gave the draft the keys to write a tag,
Trimmed the metadata tail from the bag,
Now CI hums, the rabbits sing — hi-fi! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Adding the RN Generator extra configuration' does not clearly match the actual changes, which focus on GitHub Actions workflow improvements for concurrency control and permissions management. Update the title to reflect the main changes, such as 'Add concurrency control and explicit permissions to release workflows' to accurately describe the workflow modifications.
Description check ⚠️ Warning The description provides an overview of the changes but is missing required sections from the template, including Release Notes and Related issue references. Complete the description by adding the 'Release Notes' section with specific items and the 'Related' section with any associated issue numbers.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/adding-generator-rn-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/release_draft.yml (1)

83-90: ⚠️ Potential issue | 🔴 Critical

Add tagger to github.rest.git.createTag payload (annotated tags require it).

GitHub’s REST “Create a tag object” endpoint for annotated tags requires a tagger object (at least name and email; date is optional). The current createTag payload omits tagger, so tag creation is likely to fail.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release_draft.yml around lines 83 - 90, The createTag call
is missing the required tagger object for annotated tags; update the payload
passed to github.rest.git.createTag (the call that assigns tagObject) to include
a tagger property containing at least name and email (and optional date), e.g.,
derive or set values for name/email and include them alongside tag, message
(tagMessage), object (sha) and type to ensure annotated tag creation succeeds.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/release_draft.yml:
- Around line 83-90: The createTag call is missing the required tagger object
for annotated tags; update the payload passed to github.rest.git.createTag (the
call that assigns tagObject) to include a tagger property containing at least
name and email (and optional date), e.g., derive or set values for name/email
and include them alongside tag, message (tagMessage), object (sha) and type to
ensure annotated tag creation succeeds.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fdf6e7e7-40b1-42a2-817c-e269a0ee4689

📥 Commits

Reviewing files that changed from the base of the PR and between c107a5d and d2c40fe.

📒 Files selected for processing (2)
  • .github/workflows/check_pr_release_notes.yml
  • .github/workflows/release_draft.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working no RN No release notes required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant