Adding the RN Generator extra configuration#161
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughTwo GitHub Actions workflows updated: PR release-notes checks gain concurrency control to cancel overlapping runs per ref; the release draft workflow now declares explicit permissions and creates a tag reference directly at the commit SHA instead of constructing a tag object with tagger metadata. ChangesRelease Workflow Improvements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release_draft.yml (1)
83-90:⚠️ Potential issue | 🔴 CriticalAdd
taggertogithub.rest.git.createTagpayload (annotated tags require it).GitHub’s REST “Create a tag object” endpoint for annotated tags requires a
taggerobject (at leastnameanddateis optional). The currentcreateTagpayload omitstagger, so tag creation is likely to fail.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release_draft.yml around lines 83 - 90, The createTag call is missing the required tagger object for annotated tags; update the payload passed to github.rest.git.createTag (the call that assigns tagObject) to include a tagger property containing at least name and email (and optional date), e.g., derive or set values for name/email and include them alongside tag, message (tagMessage), object (sha) and type to ensure annotated tag creation succeeds.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/release_draft.yml:
- Around line 83-90: The createTag call is missing the required tagger object
for annotated tags; update the payload passed to github.rest.git.createTag (the
call that assigns tagObject) to include a tagger property containing at least
name and email (and optional date), e.g., derive or set values for name/email
and include them alongside tag, message (tagMessage), object (sha) and type to
ensure annotated tag creation succeeds.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fdf6e7e7-40b1-42a2-817c-e269a0ee4689
📒 Files selected for processing (2)
.github/workflows/check_pr_release_notes.yml.github/workflows/release_draft.yml
Overview
This pull request introduces improvements to the GitHub Actions workflows, focusing on better workflow concurrency control and permissions management for release-related automation. The changes help prevent overlapping runs and ensure the workflows have the correct permissions to operate.
Summary by CodeRabbit