Skip to content

feat(chart): add ha resource overrides#28

Merged
coffeexcoin merged 1 commit into
mainfrom
feat/helm-ha-resource-overrides
Jun 3, 2026
Merged

feat(chart): add ha resource overrides#28
coffeexcoin merged 1 commit into
mainfrom
feat/helm-ha-resource-overrides

Conversation

@coffeexcoin
Copy link
Copy Markdown
Contributor

@coffeexcoin coffeexcoin commented Jun 3, 2026

What changed

Adds role-specific resource overrides for HA mode in the abstract-node Helm chart:

  • ha.core.resources for the HA core StatefulSet pod
  • ha.api.resources for HA API Deployment pods

Both values default to {} and fall back to the existing top-level resources value when empty, preserving the current chart behavior for existing consumers.

Impact

HA users can size the stateful core pod separately from the horizontally-scaled API pods. Non-HA users continue to use top-level resources; HA users also continue to get top-level resources for both roles unless they opt into role-specific overrides.

Validation

  • helm lint charts/abstract-node --set database.secretName=db-secret
  • helm template abstract charts/abstract-node --set database.secretName=db-secret --set ha.enabled=true --set resources.requests.cpu=7 --set resources.requests.memory=30Gi --set resources.limits.cpu=7 --set resources.limits.memory=30Gi
  • helm template abstract charts/abstract-node --set database.secretName=db-secret --set ha.enabled=true --set resources.requests.cpu=7 --set resources.requests.memory=30Gi --set resources.limits.cpu=7 --set resources.limits.memory=30Gi --set ha.api.resources.requests.cpu=1 --set ha.api.resources.requests.memory=4Gi --set ha.api.resources.limits.cpu=2 --set ha.api.resources.limits.memory=8Gi --set ha.core.resources.requests.cpu=6 --set ha.core.resources.requests.memory=28Gi --set ha.core.resources.limits.cpu=6 --set ha.core.resources.limits.memory=28Gi
  • helm template abstract charts/abstract-node --set database.secretName=db-secret --set resources.requests.cpu=7 --set resources.requests.memory=30Gi --set ha.core.resources.requests.cpu=1 --set ha.api.resources.requests.cpu=1

PR-Codex overview

This PR focuses on enhancing resource management in the Helm chart templates for deployments and stateful sets by introducing fallbacks to hierarchical resource definitions.

Detailed summary

  • Updated deployment-api.yaml to use default for resources fallback.
  • Modified statefulset.yaml to utilize ternary for conditional resource assignment.
  • Added comments in values.yaml to clarify resource requests and limits for StatefulSet and Deployment pods.
  • Introduced empty resources objects in values.yaml for both StatefulSet and API Deployment.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coffeexcoin coffeexcoin marked this pull request as ready for review June 3, 2026 12:54
@coffeexcoin coffeexcoin merged commit 685a502 into main Jun 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant