feat(chart): add ha resource overrides#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds role-specific resource overrides for HA mode in the
abstract-nodeHelm chart:ha.core.resourcesfor the HA core StatefulSet podha.api.resourcesfor HA API Deployment podsBoth values default to
{}and fall back to the existing top-levelresourcesvalue when empty, preserving the current chart behavior for existing consumers.Impact
HA users can size the stateful core pod separately from the horizontally-scaled API pods. Non-HA users continue to use top-level
resources; HA users also continue to get top-levelresourcesfor both roles unless they opt into role-specific overrides.Validation
helm lint charts/abstract-node --set database.secretName=db-secrethelm template abstract charts/abstract-node --set database.secretName=db-secret --set ha.enabled=true --set resources.requests.cpu=7 --set resources.requests.memory=30Gi --set resources.limits.cpu=7 --set resources.limits.memory=30Gihelm template abstract charts/abstract-node --set database.secretName=db-secret --set ha.enabled=true --set resources.requests.cpu=7 --set resources.requests.memory=30Gi --set resources.limits.cpu=7 --set resources.limits.memory=30Gi --set ha.api.resources.requests.cpu=1 --set ha.api.resources.requests.memory=4Gi --set ha.api.resources.limits.cpu=2 --set ha.api.resources.limits.memory=8Gi --set ha.core.resources.requests.cpu=6 --set ha.core.resources.requests.memory=28Gi --set ha.core.resources.limits.cpu=6 --set ha.core.resources.limits.memory=28Gihelm template abstract charts/abstract-node --set database.secretName=db-secret --set resources.requests.cpu=7 --set resources.requests.memory=30Gi --set ha.core.resources.requests.cpu=1 --set ha.api.resources.requests.cpu=1PR-Codex overview
This PR focuses on enhancing resource management in the Helm chart templates for deployments and stateful sets by introducing fallbacks to hierarchical resource definitions.
Detailed summary
deployment-api.yamlto usedefaultfor resources fallback.statefulset.yamlto utilizeternaryfor conditional resource assignment.values.yamlto clarify resource requests and limits for StatefulSet and Deployment pods.resourcesobjects invalues.yamlfor both StatefulSet and API Deployment.