refactor: Reuse buffers for wide string conversion on Windows#738
Open
DataTriny wants to merge 1 commit into
Open
refactor: Reuse buffers for wide string conversion on Windows#738DataTriny wants to merge 1 commit into
DataTriny wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially extracted from stacked-alloc-refactors but significantly reworked.
Introduce reusable buffers for wide string conversion in the Windows adapter to reduce memory allocations. The initial work used two separate buffers tied to the adapter instance, I chose to go with a thread-local pool of buffers, mostly to avoid acquiring a lock for each node property getter, even if they don't convert strings. Multiple adapters can also share the same buffers. I capped the buffer size to avoid keeping large memory chunks around.