Skip to content

chore(ogar-from-ruff): flip ruff deps back to branch=main (field_type merged) #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaWorldAPI merged 1 commit into from
Jun 30, 2026
Merged

chore(ogar-from-ruff): flip ruff deps back to branch=main (field_type merged) #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions crates/ogar-from-ruff/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ serde = ["dep:serde", "ogar-vocab/serde"]

[dependencies]
ogar-vocab = { path = "../ogar-vocab" }
# Temporarily pinned to the ruff `field_type` commit (rev) — `Field.field_type`
# is consumed by `project_odoo_fields` but is not yet on ruff `main`; it lands
# via the ruff PR-to-main on branch `claude/odoo-rs-transcode-lf8ya5` (this arc,
# rev 4860e79 also carries the soc operator-veto fix 101928a). Flip both back to
# `branch = "main"` once that ruff PR merges.
ruff_spo_triplet = { git = "https://github.com/AdaWorldAPI/ruff", rev = "4860e7987aa0c9453f812bb0178962d1cba66df0" }
ruff_spo_address = { git = "https://github.com/AdaWorldAPI/ruff", rev = "4860e7987aa0c9453f812bb0178962d1cba66df0" }
ruff_spo_triplet = { git = "https://github.com/AdaWorldAPI/ruff", branch = "main" }

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep ruff_spo_triplet pinned until field_type reaches main

With this dependency now resolving to ruff main, a fresh build of ogar-from-ruff pulls a ruff_spo_triplet::Field that does not yet expose field_type, while project_odoo_fields still assigns field.field_type in crates/ogar-from-ruff/src/lib.rs:228. The removed rev contains that field, so this change makes the crate fail to compile for anyone resolving dependencies from main; keep the pin or update after the upstream branch actually includes the field.

Useful? React with 👍 / 👎.

ruff_spo_address = { git = "https://github.com/AdaWorldAPI/ruff", branch = "main" }
serde = { workspace = true, optional = true }
Loading