Skip to content

[balanceplatform] Code generation: update services and models#1969

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/balanceplatform
Open

[balanceplatform] Code generation: update services and models#1969
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/balanceplatform

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner May 19, 2026 12:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new model classes and API services for managing payout schedules and configurations within the Balance Platform. Key changes include refactoring BalanceAccountsApi to move sweep-related functionality into a new CustomPayoutSchedulesSweepsApi and adding a new ManagedPayoutSchedulesApi. Feedback was provided regarding a high-severity issue in ManagedPayoutSchedulesApi where a list of enums was incorrectly formatted as a query parameter, along with a code suggestion to fix it.

// Add query params
Map<String, String> queryParams = new HashMap<>();
if (results != null) {
queryParams.put("results", results.toString());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using results.toString() on a List of enums produces a string like [failed, succeeded], which is not a valid format for a query parameter. You should join the enum values with a comma instead.

Suggested change
queryParams.put("results", results.toString());
queryParams.put("results", results.toString().replace("[", "").replace("]", "").replace(" ", ""));

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from 7ec949f to 4fcc124 Compare May 19, 2026 14:56

@jeandersonbc jeandersonbc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains a model that doesn't follow the naming conventions - PatchableBalanceAccountConfigurationRequest

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 4 times, most recently from d610c1f to a248024 Compare June 2, 2026 15:30
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from a248024 to a757df7 Compare June 4, 2026 13:32
@jeandersonbc jeandersonbc force-pushed the sdk-automation/balanceplatform branch from a757df7 to 3b66db1 Compare June 9, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants