Feat/settings page revamp#2797
Conversation
Replace the settings cards with a Figma-aligned settings layout (theme, Connect Mobile, updates, feedback), move sidebar entry points into Settings, and drop the standalone /prs board in favor of session inspector PRs.
Vaibhaav-Tiwari
left a comment
There was a problem hiding this comment.
-
Settings page may break on Windows
The new Settings page hides the topbar, but the sidebar can move up and cover the Windows title/menu bar. -
Secret scanning was weakened too much
The PR allowlists whole files in gitleaks just because of a LinkedIn false positive. That could hide real secrets later. -
Docs still mention /prs
The PR removes the /prs page, but the public docs still tell users to open /prs. -
Global Settings telemetry is incomplete
The new /settings route is reported as other instead of something like global_settings.
Drop whole-file gitleaks allowlists, document /settings instead of /prs, and report /settings as global_settings.
codebanditssss
left a comment
There was a problem hiding this comment.
i tested the new settings page and related flows in the linux desktop app and everything is working nicely. i also reviewed the theme handling, updates, connect mobile, feedback flow, sidebar changes, and removal of the standalone pr page. the code looks clean and the relevant tests are passing. approved.
Offset the sidebar under the WindowTitlebar on settings and drop the duplicate collapsed-rail expand control.
Replace the separate header expand/collapse triggers with one SidebarTrigger so the rail no longer shows duplicate controls.
Vaibhaav-Tiwari
left a comment
There was a problem hiding this comment.
lgtm now
just resolve prettier and will merge
|
From the NotesBot call on Relevant discussion excerpts:
Source thread: https://discord.com/channels/1476302178913357958/1528463891200217212/1528463891200217212 Generated by AO Bot based on the transcript from NotesBot. |
Summary
/prsboard (PRs stay in the session inspector), stop mounting the first-run MigrationPopup on home while keepingMigrationSectionfor a later Settings integrationIntentional omissions
Test plan
/prsis gone, session inspector still lists stacked PRsBefore
After