Skip to content

Feat/settings page revamp#2797

Open
Annieeeee11 wants to merge 13 commits into
mainfrom
feat/settings-page-revamp
Open

Feat/settings page revamp#2797
Annieeeee11 wants to merge 13 commits into
mainfrom
feat/settings-page-revamp

Conversation

@Annieeeee11

Copy link
Copy Markdown
Collaborator

Summary

  • Rebuild Global Settings to the Figma layout: General (theme + Connect Mobile), Updates, Feedback, and social links, with shared settings primitives and tokens
  • Route sidebar Settings straight to /settings, move Feedback / Connect Mobile / theme out of the sidebar menu into Settings
  • Add Light / Dark / System theme preference with live OS sync when System is selected, auto-save update channel toggles (no Save button)
  • Restyle Connect Mobile + Report a problem dialogs, unify modal/sheet overlays with a shared blurred scrim
  • Remove the standalone /prs board (PRs stay in the session inspector), stop mounting the first-run MigrationPopup on home while keeping MigrationSection for a later Settings integration

Intentional omissions

  • Migration is not re-added to Settings in this PR (MigrationSection remains available to wire later)
  • No replacement global PR surface, session inspector remains the desktop PR entry point

Test plan

  • Sidebar Settings → /settings: close returns home; topbar hidden on settings routes
  • Theme Light / Dark / System persists, System follows OS appearance changes
  • Updates: enable/disable + channel auto-save,nightly warning, check / download / install still work
  • Connect Mobile from Settings: enable, QR/password, regenerate
  • Feedback: Title/Brief → GitHub / Discord / Email, drafts redact local paths/URLs/secrets, correct destinations open
  • /prs is gone, session inspector still lists stacked PRs
  • Fresh launch no longer shows MigrationPopup

Before

image

After

image image image image image image image

Replace the settings cards with a Figma-aligned settings layout (theme,
Connect Mobile, updates, feedback), move sidebar entry points into
Settings, and drop the standalone /prs board in favor of session
inspector PRs.
@Annieeeee11 Annieeeee11 self-assigned this Jul 18, 2026
@Annieeeee11
Annieeeee11 requested a review from JAYATIAHUJA July 18, 2026 20:20

@Vaibhaav-Tiwari Vaibhaav-Tiwari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Settings page may break on Windows
    The new Settings page hides the topbar, but the sidebar can move up and cover the Windows title/menu bar.

  2. Secret scanning was weakened too much
    The PR allowlists whole files in gitleaks just because of a LinkedIn false positive. That could hide real secrets later.

  3. Docs still mention /prs
    The PR removes the /prs page, but the public docs still tell users to open /prs.

  4. Global Settings telemetry is incomplete
    The new /settings route is reported as other instead of something like global_settings.

Drop whole-file gitleaks allowlists, document /settings instead of /prs, and report /settings as global_settings.

@Vaibhaav-Tiwari Vaibhaav-Tiwari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, the new Settings page may let the sidebar overlap the custom title/menu bar.

@codebanditssss codebanditssss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

i tested the new settings page and related flows in the linux desktop app and everything is working nicely. i also reviewed the theme handling, updates, connect mobile, feedback flow, sidebar changes, and removal of the standalone pr page. the code looks clean and the relevant tests are passing. approved.

Offset the sidebar under the WindowTitlebar on settings and drop the duplicate collapsed-rail expand control.
Replace the separate header expand/collapse triggers with one SidebarTrigger so the rail no longer shows duplicate controls.

@Vaibhaav-Tiwari Vaibhaav-Tiwari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now
just resolve prettier and will merge

@i-trytoohard

Copy link
Copy Markdown
Contributor

From the NotesBot call on 2026-07-19, this existing pr appears to be relevant.
Match confidence: 0.94 (fuzzy).

Relevant discussion excerpts:

    • Started exploring custom loops earlier but paused when learning harshitsingh had parallel work; design doc already shared with prateek. - harshitsingh clarified custom loops work was exploratory on a fork; “significant progress,” but not ready to present yet; agreed to align via design doc review first [...]
    • Anaya: working on two PRs: “settings page revamp” + “design page”; incorporating prateek’s suggestions. - Previously joined last Sunday; created a bug-fix PR “in the tracker intake.” - .phylolver(vaibhaav): “session timeline… will be better in the redesign,” but prateek reiterated not to wait for redesign for [...]
    • harshitsingh clarified custom loops work was exploratory on a fork; “significant progress,” but not ready to present yet; agreed to align via design doc review first (prateek: “start with design doc”). - Anaya: working on two PRs: “settings page revamp” + “design page”; incorporating prateek’s suggestions.

Source thread: https://discord.com/channels/1476302178913357958/1528463891200217212/1528463891200217212

Generated by AO Bot based on the transcript from NotesBot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants