feat: add configured base URL support to client - #64
Merged
Conversation
- Introduced functionality to use an internal fixed base URL for API requests based on the AGORA_AGENTS_INTERNAL_API_BASE_URL environment variable. - Updated the Pool class to disable dynamic domain selection when a fixed base URL is set. - Added tests to verify the correct behavior of the new base URL feature and its impact on domain selection.
- Updated the environment variable from AGORA_AGENTS_INTERNAL_API_BASE_URL to AGORA_AGENTS_API_BASE_URL for clarity. - Refactored related functions and tests to reflect the new naming convention. - Ensured that the Pool class and its methods utilize the updated base URL for domain selection and routing.
seymourtang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.