Skip to content

[ALICE3] Add method to specify dead phi region in layer#13119

Merged
njacazio merged 6 commits into
masterfrom
njacazio-patch-3
Sep 26, 2025
Merged

[ALICE3] Add method to specify dead phi region in layer#13119
njacazio merged 6 commits into
masterfrom
njacazio-patch-3

Conversation

@njacazio

Copy link
Copy Markdown
Collaborator

Added method to define a dead region in phi for a layer.

Added method to define a dead region in phi for a layer.
@github-actions

github-actions Bot commented Sep 24, 2025

Copy link
Copy Markdown

O2 linter results: ❌ 90 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add method to specify dead phi region in layer [ALICE3] Add method to specify dead phi region in layer Sep 24, 2025
@njacazio

Copy link
Copy Markdown
Collaborator Author

@jesgum this is the starting point

@njacazio njacazio marked this pull request as ready for review September 25, 2025 11:39
@njacazio

Copy link
Copy Markdown
Collaborator Author

@jesgum tested with the macro, moving on

@njacazio njacazio enabled auto-merge (squash) September 25, 2025 11:40
alibuild
alibuild previously approved these changes Sep 25, 2025

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

Comment thread ALICE3/Core/DetLayer.cxx Outdated
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
alibuild
alibuild previously approved these changes Sep 25, 2025

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit 61e9d67 into master Sep 26, 2025
11 of 15 checks passed
@njacazio njacazio deleted the njacazio-patch-3 branch September 26, 2025 17:55
jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants