Skip to content

[ALICE3] Update LUT configurations to default empty values for nuclei#13400

Merged
njacazio merged 11 commits into
masterfrom
njacazio-patch-5
Oct 16, 2025
Merged

[ALICE3] Update LUT configurations to default empty values for nuclei#13400
njacazio merged 11 commits into
masterfrom
njacazio-patch-5

Conversation

@njacazio

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown

O2 linter results: ❌ 18 errors, ⚠️ 24 warnings, 🔕 0 disabled

@njacazio njacazio changed the title Update LUT configurations to allow empty values Update LUT configurations to default empty values for nuclei Oct 15, 2025
@github-actions github-actions Bot changed the title Update LUT configurations to default empty values for nuclei [ALICE3] Update LUT configurations to allow empty values Oct 15, 2025
@njacazio njacazio marked this pull request as ready for review October 15, 2025 13:12
@njacazio njacazio enabled auto-merge (squash) October 15, 2025 13:12
alibuild
alibuild previously approved these changes Oct 15, 2025

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio disabled auto-merge October 15, 2025 13:39
@njacazio njacazio enabled auto-merge (squash) October 15, 2025 13:39
alibuild
alibuild previously approved these changes Oct 15, 2025

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio

Copy link
Copy Markdown
Collaborator Author

@jesgum

@njacazio njacazio changed the title [ALICE3] Update LUT configurations to allow empty values [ALICE3] Update LUT configurations to default empty values for nuclei Oct 15, 2025
@njacazio njacazio disabled auto-merge October 15, 2025 13:41
@njacazio njacazio enabled auto-merge (squash) October 15, 2025 13:41
alibuild
alibuild previously approved these changes Oct 15, 2025

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@jesgum

jesgum commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator

Many thanks @njacazio! Some of these changes i've included in #13325

Specifically for the nuclei, where instead the loading of the luts is behind the existing treat nuclei flag

That pr also introduces the option to use the fassttracker instead if LUTs for primaries which is a feature that I think we want. Should I reopen the pr with only the fasttracker changes or how do we want to proceed?

@njacazio njacazio disabled auto-merge October 15, 2025 14:03
@njacazio njacazio enabled auto-merge (squash) October 15, 2025 14:04

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit 7b8296a into master Oct 16, 2025
13 of 15 checks passed
@njacazio njacazio deleted the njacazio-patch-5 branch October 16, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants