Remove timestamp from non-response events#119
Conversation
|
looping in @arjunsridhar12345 since this will create a breaking change in the data format. @arjunsridhar12345 Please review these changes |
|
@alexpiet does this register auto responses how you expect? It seems like this will still immediately end the response time period when there is an automatic water event. I am unclear if that is the desired approach. |
|
I dont understand what this PR is changing. The delivering of auto-water should not impact the timing of subsequent events |
Ok lets turn this into a question: What should the response time be when the animals get auto-water? Similarly, what should the response time be if the animals go over the choice deadline? |
The response time should be the time in which the animal licks, that is the time in which the animal makes a response
The same as any other ignored trial |
I think we may have misunderstood the auto-water. I thought that when auto-water is given, the trial finishes. It sounds like what you want is to drop a little bit of water at the spout and proceed with the trial as usual. Can you confirm? |
6149d29 to
c728afb
Compare
|
Yes, auto-water is water that is given at the go cue |
|
Can the animal be rewarded twice in that trial then? |


This PR introduces a breaking change to the
Responsesoftware event:Bonsai.Harp.Timestamp<T>constructor does not accept NaN as a timestamp, we introduce a breaking change by serializing asTuple<Nullable<bool>, double>instead.This should make the decision to only include hw-derived timestamps in this event more systematic and introduce less downstream analysis issues like in #118
Closes #118